Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(athena): regen snapshots for first/last value #10740

Merged
merged 1 commit into from
Jan 28, 2025
Merged

test(athena): regen snapshots for first/last value #10740

merged 1 commit into from
Jan 28, 2025
+2 −2

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 28, 2025

Fix failing athena test on main.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis tests Issues or PRs related to tests ci Continuous Integration issues or PRs athena The Amazon Athena backend labels Jan 28, 2025
@cpcloud cpcloud added this to the 10.0 milestone Jan 28, 2025
@cpcloud
Copy link
Member Author

cpcloud commented Jan 28, 2025

The single failing test from this CI run is now passing:

…/ibis on  fix-athena-snapshot is 📦 v9.5.0 via 🐍 v3.12.8 via ❄️  impure (ibis-3.12-env)
❯ pytest 'ibis/backends/tests/test_sql.py::test_union_aliasing[athena]' --snapshot-update -q
.                                                                                                                                                                                              [100%]
1 passed in 0.32s

@cpcloud cpcloud merged commit 2651fbd into ibis-project:main Jan 28, 2025
92 of 93 checks passed
@cpcloud cpcloud deleted the fix-athena-snapshot branch January 28, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
athena The Amazon Athena backend bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs tests Issues or PRs related to tests
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@cpcloud