fix(bigquery): let bigquery backend respect window frame set by users #10700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bigquery
maxshine
force-pushed
the
fix-issue-10699
branch
from
1546c5f to
352220f
Compare
maxshine
changed the title
maxshine
changed the title
|
This PR breaks a bunch of BigQuery tests. Let's chat on the issue first, since it's not clear there's actually a bug here. |
1 task
|
Hi @cpcloud As I observed from CI workflow, Bigquery backend test suites were successful 
Would you please kindly point me to the failed cases and I am happy to contribute to the corresponding tests? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removed the bigquery specific logic dropping window frame of
BETWEEN UNBOUND PRECEDING AND CURRENT ROWso it will keep the window frame as set by users.Issues closed