refactor(api)!: change as_interval unit argument to be positional…

…-only
ibis-project · Feb 5, 2025 · a85d497 · a85d497
1 parent 926aa90
commit a85d497
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/ibis/backends/tests/test_temporal.py b/ibis/backends/tests/test_temporal.py
@@ -556,7 +556,7 @@ def test_date_truncate(backend, alltypes, df, unit):
 def test_integer_to_interval_timestamp(
     backend, con, alltypes, df, unit, displacement_type
 ):
-    interval = alltypes.int_col.as_interval(unit=unit)
+    interval = alltypes.int_col.as_interval(unit)
     expr = (alltypes.timestamp_col + interval).name("tmp")
 
     def convert_to_offset(offset, displacement_type=displacement_type):
@@ -629,7 +629,7 @@ def convert_to_offset(offset, displacement_type=displacement_type):
 @pytest.mark.notimpl(["datafusion", "druid"], raises=com.OperationNotDefinedError)
 @pytest.mark.notimpl(["exasol"], raises=com.OperationNotDefinedError)
 def test_integer_to_interval_date(backend, con, alltypes, df, unit):
-    interval = alltypes.int_col.as_interval(unit=unit)
+    interval = alltypes.int_col.as_interval(unit)
     month = alltypes.date_string_col[:2]
     day = alltypes.date_string_col[3:5]
     year = alltypes.date_string_col[6:8]

diff --git a/ibis/expr/types/numeric.py b/ibis/expr/types/numeric.py
@@ -1454,6 +1454,7 @@ def as_timestamp(self, unit: Literal["s", "ms", "us"], /) -> ir.TimestampValue:
     def as_interval(
         self,
         unit: Literal["Y", "M", "W", "D", "h", "m", "s", "ms", "us", "ns"] = "s",
+        /,
     ) -> ir.IntervalValue:
         """Convert an integer to an interval.
 
@@ -1518,8 +1519,9 @@ def to_timestamp(
     def to_interval(
         self,
         unit: Literal["Y", "M", "W", "D", "h", "m", "s", "ms", "us", "ns"] = "s",
+        /,
     ) -> ir.IntervalValue:
-        return self.as_interval(unit=unit)
+        return self.as_interval(unit)
 
     def convert_base(
         self,