IBX-8471: Fixed Varnish::queueRequest implementation after SF 7 upgrade #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ibx-8471-post-merge-fixes
branch
from
3ef6e18 to
9f1df3c
Compare
ViniTou
approved these changes
May 12, 2025
adamwojs
approved these changes
May 12, 2025
alongosz
force-pushed
the
ibx-8471-post-merge-fixes
branch
2 times, most recently
from
6ff95f7 to
f61de54
Compare
alongosz
force-pushed
the
ibx-8471-post-merge-fixes
branch
from
f61de54 to
5e1a6b1
Compare
Interfaces are already announced in '\FOS\HttpCache\ProxyClient\Varnish'
alongosz
force-pushed
the
ibx-8471-post-merge-fixes
branch
from
67bc28d to
86c215b
Compare
konradoboza
approved these changes
May 13, 2025
alongosz
force-pushed
the
ibx-8471-post-merge-fixes
branch
from
86c215b to
88a2672
Compare
This was referenced May 13, 2025
alongosz
force-pushed
the
ibx-8471-post-merge-fixes
branch
3 times, most recently
from
3e2a4ae to
88a2672
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Related PRs:
APP_SECRETfor Behat tests gh-workflows#61APP_SECRETin docker images for Symfony 7.2 docker#40Description:
Passed missing
$validateHostto parent\FOS\HttpCache\ProxyClient\Varnishin\Ibexa\HttpCache\ProxyClient\Varnish::queueRequestimplementation.For QA:
Passing regression tests.