Skip to content

[CI] Normalized expected headers names to lowercase #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

[CI] Normalized expected headers names to lowercase #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc3da2f
Normalized expected headers names to lowercase
ViniTou Mar 12, 2025
26f4c14
Fixed double colon in controller route definition
ViniTou Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions features/symfony/cache.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ Feature: As an site administrator I want my pages to be cached using Symfony Htt
| title | <itemName> |
And response headers contain
| Header | Value |
| Cache-Control | public, s-maxage=86400 |
| X-Symfony-Cache | <headerValue> |
| cache-control | public, s-maxage=86400 |
| x-symfony-cache | <headerValue> |


Examples:
Expand Down Expand Up @@ -43,8 +43,8 @@ Feature: As an site administrator I want my pages to be cached using Symfony Htt
| title | <itemNameAfterEdit> |
And response headers contain
| Header | Value |
| Cache-Control | public, s-maxage=86400 |
| X-Symfony-Cache | <headerValue> |
| cache-control | public, s-maxage=86400 |
| x-symfony-cache | <headerValue> |

Examples:
| user | password | itemName | itemNameAfterEdit | headerValue |
Expand Down
8 changes: 4 additions & 4 deletions features/symfony/embed.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ Feature: Caching of embedded items
And I should see "<embeddedItemName>"
And response headers contain
| Header | Value |
| Cache-Control | public, s-maxage=86400 |
| X-Symfony-Cache | <headerValue> |
| cache-control | public, s-maxage=86400 |
| x-symfony-cache | <headerValue> |
When I edit "<embeddedItemName>" Content item in "eng-GB"
| name |
| <editedEmbeddedItemName> |
Expand Down Expand Up @@ -52,10 +52,10 @@ Feature: Caching of embedded items
And I should see "<embeddedItemName>"
And response headers contain
| Header | Value |
| Cache-Control | public, s-maxage=86400 |
| cache-control | public, s-maxage=86400 |
And response headers match pattern
| Header | Pattern |
| X-Symfony-Cache | <expectedPattern> |
| x-symfony-cache | <expectedPattern> |

Examples:
| embeddingItemName | embeddedItemName | expectedPattern |
Expand Down
8 changes: 4 additions & 4 deletions features/symfony/permissions.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ Feature: Cached response is different for users with different permissions
And I should see "Administrator User"
And response headers contain
| Header | Value |
| Cache-Control | public, s-maxage=86400 |
| X-Symfony-Cache | GET /site/Users/Administrator-users/Administrator-User: fresh |
| cache-control | public, s-maxage=86400 |
| x-symfony-cache | GET /site/Users/Administrator-users/Administrator-User: fresh |
When I am viewing the pages on siteaccess "site" as "Anonymous"
And I visit "Users/Administrator-users/Administrator-User" on siteaccess "site"
Then I should not see "Administrator User"
Expand All @@ -32,8 +32,8 @@ Feature: Cached response is different for users with different permissions
And I should see "Administrator User"
And response headers contain
| Header | Value |
| Cache-Control | public, s-maxage=86400 |
| X-Symfony-Cache | GET /site/testcontentitem: fresh |
| cache-control | public, s-maxage=86400 |
| x-symfony-cache | GET /site/testcontentitem: fresh |
When I am viewing the pages on siteaccess "site" as "Anonymous"
And I visit "TestContentItem" on siteaccess "site"
Then I should see "TestContentItem"
Expand Down
8 changes: 4 additions & 4 deletions features/varnish/cache.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ Feature: As an site administrator I want my pages to be cached using Varnish
When I visit <itemName> on siteaccess "site"
And response headers contain
| Header | Value |
| X-Cache | MISS |
| x-cache | MISS |
And I reload the page
Then I see correct preview data for "Folder" content type
| field | value |
| title | <itemName> |
And response headers contain
| Header | Value |
| X-Cache | HIT |
| x-cache | HIT |

Examples:
| user | password | itemName |
Expand All @@ -37,7 +37,7 @@ Feature: As an site administrator I want my pages to be cached using Varnish
| title | <itemName> |
And response headers contain
| Header | Value |
| X-Cache | HIT |
| x-cache | HIT |
When I edit "<itemName>" Content item in "eng-GB"
| short_name |
| <itemNameAfterEdit> |
Expand All @@ -52,7 +52,7 @@ Feature: As an site administrator I want my pages to be cached using Varnish
| title | <itemNameAfterEdit> |
And response headers contain
| Header | Value |
| X-Cache | HIT |
| x-cache | HIT |

Examples:
| user | password | itemName | itemNameAfterEdit |
Expand Down
4 changes: 2 additions & 2 deletions features/varnish/embed.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Feature: Caching of embedded items
And I should see "<embeddedItemName>"
And response headers contain
| Header | Value |
| X-Cache | HIT |
| x-cache | HIT |
When I edit "<embeddedItemName>" Content item in "eng-GB"
| name |
| <editedEmbeddedItemName> |
Expand Down Expand Up @@ -54,7 +54,7 @@ Feature: Caching of embedded items
And I should see "<embeddedItemName>"
And response headers contain
| Header | Value |
| X-Cache | HIT |
| x-cache | HIT |

Examples:
| embeddingItemName | embeddedItemName |
Expand Down
4 changes: 2 additions & 2 deletions features/varnish/permissions.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Feature: Cached response is different for users with different permissions
And I should see "Administrator User"
And response headers contain
| Header | Value |
| X-Cache | HIT |
| x-cache | HIT |
When I am viewing the pages on siteaccess "site" as "Anonymous"
And I visit "Users/Administrator-users/Administrator-User" on siteaccess "site"
Then I should not see "Administrator User"
Expand All @@ -30,7 +30,7 @@ Feature: Cached response is different for users with different permissions
And I should see "Administrator User"
And response headers contain
| Header | Value |
| X-Cache | HIT |
| x-cache | HIT |
When I am viewing the pages on siteaccess "site" as "Anonymous"
And I visit "TestContentItem" on siteaccess "site"
Then I should see "TestContentItem"
Expand Down
4 changes: 2 additions & 2 deletions features/varnish/translations.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Feature: As an site administrator I want my pages to be cached using Varnish
| title | <itemName> |
And response headers contain
| Header | Value |
| X-Cache | HIT |
| x-cache | HIT |
When I edit "<itemName>" Content item in "eng-GB"
| short_name |
| <itemNameAfterEdit> |
Expand All @@ -28,7 +28,7 @@ Feature: As an site administrator I want my pages to be cached using Varnish
| title | <itemNameAfterEdit> |
And response headers contain
| Header | Value |
| X-Cache | HIT |
| x-cache | HIT |

Examples:
| user | password | itemName | itemNameAfterEdit |
Expand Down
2 changes: 1 addition & 1 deletion src/bundle/Resources/config/routing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ibexa.http_cache.invalidate_token:
path: /_ibexa_http_invalidatetoken
defaults:
_controller: Ibexa\Bundle\HttpCache\Controller\InvalidateTokenController:tokenAction
_controller: Ibexa\Bundle\HttpCache\Controller\InvalidateTokenController::tokenAction
Loading