-
Notifications
You must be signed in to change notification settings - Fork 85
IBX-9904: Workflow to build API refs into new PR #2723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Preview of modified files: no change to preview. |
version: | ||
description: 'Released version' | ||
required: true | ||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used to build the references, only to create the branch.
- The script could evolve to receive version as an argument instead of alway building for the latest version (Is there a need for building old references?).
- Or just rename the inputs being renamed to avoid ambiguity (my favorite).
version: | |
description: 'Released version' | |
required: true | |
type: string | |
branch_suffix: | |
description: "Used in branch name to open PR for the latest version's references" | |
required: true | |
type: string |
uses: actions/checkout@v4 | ||
|
||
- name: Build API Refs | ||
# TODO: On 5.0, update tool to handle both PHP & REST APIs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To do this, few lines can be added to the 5.0 version of phpdoc.sh:
$PHP_BINARY bin/console ibexa:openapi --yaml > openapi.yaml
redocly build-docs openapi.yaml --output $(realpath $OUTPUT_DIR/../../rest_api/rest_api_reference/rest_api_reference.html)
Anyway, the tool should be renamed and reworked to reflect its new task of building both references.
Create a workflow that can be triggered to build
On ibexa/commerce-skeletonhttps://github.com/ibexa/commerce-skeleton/blob/master/.github/workflows/ can then be added a workflow like the following:
Checklist