-
Notifications
You must be signed in to change notification settings - Fork 85
Added documentation for udw_config_name #2719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
When creating a block with these two types you can configure the UDW behavior. | ||
|
||
For more information, see [Create custom page block / Add edit template](create_custom_page_block.md#add-edit-template) | ||
When creating a block with these two types you can use the `udw_config_name` option to configure the UDW behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about removing this part:
For more information, see [Create custom page block / Add edit template](create_custom_page_block.md#add-edit-template)
Is udw_config_name
enough or are there still any "special cases" where you need to overwrite the template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
udw_config_name
is sufficient, ie:
banner:
attributes:
contentId:
options:
udw_config_name: udw_banner_config
I'm not sure about removing this part:
(....)
I think it can remain. Why remove it?
Btw, there is also a embedvideo
attribute type which seems to not be mentioned in documentation. udw_config_name
works for that attribute type too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reasoning was that if I can change the UDW config for the block attribute in two ways:
- by using the
udw_config_name
- by overriding the template
And both of them achieve the same goal, but one of them is much simpler then we should recommend only the simple one.
I'd leave it only if it's like this:
- use
udw_config_name
to specify the UDW config (covers 90% of the cases) - override the template to achieve an adidtional goal (which one? I could mention it in the custom block example )
After this discussion I've decided to double down on this and rewrote the custom block example so that it uses udw_config_name
.
Btw, there is also a embedvideo attribute type which seems to not be mentioned in documentation. udw_config_name works for that attribute type too
Thanks, mentioned now!
Preview of modified filesPreview of modified Markdown: |
efe23ee
to
d894809
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good beside small comment
Thank for you review Vidar, I've decided to partially revert changes from #2331 and show how to do this using the |
code_samples/ change report
|
Target: master, 4.6
Doc for https://github.com/ibexa/fieldtype-page/pull/128
Preview: https://ez-systems-developer-documentation--2719.com.readthedocs.build/en/2719/content_management/pages/page_block_attributes/