-
Notifications
You must be signed in to change notification settings - Fork 85
IBX-8190: Update REST new resource #2682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Preview of modified Markdown: |
out of scope
out of scope
Fix the following for low coast Parameter #1 $string of function substr expects string, string|false given.
Try to avoid "Call to function is_array() with array will always evaluate to true."
code_samples/ change report
|
if ('json' === $format) { | ||
$data = $data[array_key_first($data)]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unwrap JSON.
I could even test that 'GreetingInput' === array_key_first($data)
if ('json' === $format) { | ||
$data = $data[array_key_first($data)]; | ||
} | ||
$data = array_change_key_case($data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make node name case insensitive. Could be removed for more strictness.
GET /greet
andPOST /greet
to schema/doc (/api/ibexa/v2/doc#/App/api_greet_get
).Preview: Creating new REST resource
Checklist