IBX-4498: raml2html: Upgrade dependencies #1871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriendupuis
changed the title
DominikaK
force-pushed
the
master
branch
3 times, most recently
from
33f6b7e to
2b50cbd
Compare
adriendupuis
commented
Feb 9, 2023
7 tasks
adriendupuis
commented
Feb 16, 2023
# Conflicts: # tools/raml2html/composer.json
adriendupuis
commented
Feb 16, 2023
adriendupuis
commented
Feb 16, 2023
adriendupuis
force-pushed
the
update-raml2html
branch
from
6986765 to
b7b829c
Compare
Avoid "Deprecated: mb_strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in tools/raml2html/vendor/raml-org/raml-php-parser/src/Parser.php on line 696"
https://getcomposer.org/doc/01-basic-usage.md#commit-your-composer-lock-file-to-version-control Generated while using PHP 8.1.15 Application tested with PHP 8.1.15 and 8.2.2
adriendupuis
force-pushed
the
update-raml2html
branch
from
b59d7e3 to
51bd16a
Compare
adriendupuis
changed the title
adriendupuis
commented
Feb 23, 2023
# Conflicts: # docs/api/rest_api/rest_api_reference/input/ez-types.raml
adriendupuis
commented
Mar 22, 2023
adriendupuis
force-pushed
the
update-raml2html
branch
from
3788487 to
97d347e
Compare
* Without a composer.lock - `composer install` installs the packages corresponding to the used PHP and generate a local composer.lock * With a tracked composer.lock - `composer install` installs the PHP8.0-compatible packages. After that the build command has forward compatibility and works with PHP8.0, 8.1 and 8.2. - `composer update` updates to maximum package version adapted to the currently used PHP, potentially breaking backward compatibility, overwrite the composer.lock but the user shouldn't commit it while it appears in the changes: it's a trap!
# Conflicts: # docs/api/rest_api/rest_api_reference/input/ez-types.raml # docs/api/rest_api/rest_api_reference/rest_api_reference.html
adamwojs
approved these changes
Jul 7, 2023
MagdalenaZuba
approved these changes
Jul 7, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to PHP 8.0+
I moved from slightly out-dated adamwojs/raml-php-parser (forked around v4.6.1) back to raml-org/raml-php-parser for actual v4.8.1 and next versions. It should be easier to keep up-to-date using
composer updatethan synchronising a repository. I still use modifications from Ibexa members thanks to cweagans/composer-patches. If one day, those patches are rejected, we'll improvise.This needed some fixes in the RAML files started a bit with #1642 and mainly ended in #2042.
How-to update: default PHP must 8.2, 8.1 or 8.0 to reinstall with the following commands:
Checklist