Enhanced exception for createContent #670
Conversation
|
| $exception->setMessageTemplate('Content "%contentName%" fields did not validate: %errors%'); | ||
| $exception->setMessageTemplate('Content%contentName%fields did not validate: %errors%'); | ||
| $exception->setParameters([ | ||
| '%errors%' => $exception->generateValidationErrorsMessages(), | ||
| '%contentName%' => $exception->contentName !== null ? $exception->contentName : '', | ||
| '%contentName%' => $exception->contentName !== null ? ' "' . $exception->contentName . '" ' : ' ', |
There was a problem hiding this comment.
Why is this change needed? I think we cannot have empty contentName or do we?
There was a problem hiding this comment.
In function createContent when throwing the error we do not yet have a Content Object - just $contentCreateStruct and no contentName.
Even in updateContent we might have errors in fields that make contentName empty.
But you are right, the above looks 'unmotivated'.
Main reason for the change was the existing test https://github.com/ibexa/core/blob/main/tests/lib/Repository/Service/Mock/ContentTest.php#L2498 that checks the error message.
More specific:
Without the above change, the new error message for createContent will be:
Content "" fields did not validate:
- ..
- ...
This lets the test fail, as it expects Content fields did not validate .
Probably better to change the test ...
5 participants
PR adds enhanced exception handling to
contentCreate(
ContentFieldValidationException::createNewWithMultiline($errors)was introduced in ezsystems/ezplatform-kernel#329)Without PR, thrown errors will show up as :
With PR, details regarding affected fields will be shown: