fix(backend): satisfy prettier + eslint on CORS helper (unblock main CI)#216
fix(backend): satisfy prettier + eslint on CORS helper (unblock main CI)#216ianlintner wants to merge 3 commits into
Conversation
- Keep CAT_HERDING_ORIGIN_RE on a single line (prettier) - Wrap all early-return 'if' bodies in braces to satisfy eslint curly rule Unblocks main CI so the embed bundle can be rebuilt and the widget unauthenticated + dark theme fixes from #211 can actually ship.
|
@claude caretaker is requesting a full code review for this PR. Repo: Please review this pull request for:
Post a review comment summary and inline comments where applicable. Delegated by caretaker's PRReviewerAgent via ClaudeCodeExecutor hand-off. |
|
This PR requires human attention. Reason: Open >24h with no human approval — needs review The automated system has exhausted its ability to resolve this. Please review and take appropriate action. Escalation debug dumpGenerated at: {
"debug": {
"copilot_attempts": 0,
"fix_cycles": 0,
"pr_age_hours": 722.5996325355557,
"recommended_action": "escalate",
"stuck_age_hours": 24,
"stuck_confidence": 0.5,
"stuck_reason": "abandoned"
},
"owner": "ianlintner",
"pull_request": {
"base_ref": "main",
"draft": false,
"head_ref": "fix/ci-lint-format-post-merge",
"html_url": "https://github.com/ianlintner/Example-React-AI-Chat-App/pull/216",
"is_copilot_pr": false,
"is_maintainer_pr": true,
"mergeable": null,
"number": 216,
"state": "open",
"title": "fix(backend): satisfy prettier + eslint on CORS helper (unblock main CI)"
},
"reason": "Open >24h with no human approval \u2014 needs review",
"repo": "Example-React-AI-Chat-App",
"type": "pr_escalation"
} |
There was a problem hiding this comment.
{
"summary": "This PR fixes formatting and linting issues by adding braces to conditional statements and reformatting code to satisfy prettier and eslint rules. The changes are purely stylistic with no functional modifications to the CORS logic.",
"verdict": "APPROVE",
"comments": []
}|
@copilot please fix ci type errors |
Fixed in 33c3a31. The CI |
Why
PR #211 merged successfully but the follow-up CI on
mainfailed on two steps:prettier --check .) —backend/src/index.tswas not prettier-clean.eslint src --ext .ts) — 2 errors + 4curlywarnings in the new CORS helper.As a consequence the embed bundle was never rebuilt/redeployed, so the production widget at
chat.cat-herding.net/embed/cat-herding-chat.jsis still the old Apr 22 version: still light-themed, sign-in gate still takes the full panel, input row still hidden when unauthed. The CORS fix is live (backend image was rebuilt separately), but the widget UX fixes from #211 are invisible to users until CI goes green here.What
backend/src/index.ts:CAT_HERDING_ORIGIN_REassignment + regex literal onto a single line (prettier).if (...) return true;insideisAllowedOrigin()in{ ... }braces to satisfyeslint-plugin-*curlyrule.No functional change — the CORS decision logic is identical.
Verification
101:30 error Delete ⏎·119:7 error Replace ... with ...117:16, 118:43, 120:5, 122:5 warning Expected { after 'if' conditionAfter merging
CI on
mainshould go green, the embed bundle gets rebuilt, andchat.cat-herding.net/embed/cat-herding-chat.jsstarts serving the dark-themed + always-on input + compact sign-in banner version. Portfolio/chatpage will pick it up automatically on next load.