make runtime respect options.path
#13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcppman
force-pushed
the
fix-custom-path-issue
branch
2 times, most recently
from
9d2dfe5 to
a4d4991
Compare
when using cargo-web's built-in backend, the generated standalone runtime hardcoded file path as 'xxx.wasm'. It causes error when the .wasm file is at that location. Thus we use a custom runtime instead to get the .wasm from the correct location.
jcppman
force-pushed
the
fix-custom-path-issue
branch
from
a4d4991 to
d48f7a3
Compare
|
Thank you for this patch Chriest, will review!
…On Wed., Jun. 19, 2019, 4:45 a.m. Chriest Yu, ***@***.***> wrote:
This fixes ianjsikes/rust-wasm-webpack-tutorial#7
<ianjsikes/rust-wasm-webpack-tutorial#7>
when using cargo-web's built-in backend, the generated standalone
runtime hardcoded file path as 'xxx.wasm'. It causes error when
the .wasm file is at that location. Thus we use a custom runtime instead to
get the .wasm from the correct location.
------------------------------
You can view, comment on, or merge this pull request online at:
#13
Commit Summary
- make runtime respect `options.path`
File Changes
- *M* index.js
<https://github.com/ianjsikes/rust-wasm-loader/pull/13/files#diff-0>
(25)
Patch Links:
- https://github.com/ianjsikes/rust-wasm-loader/pull/13.patch
- https://github.com/ianjsikes/rust-wasm-loader/pull/13.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#13?email_source=notifications&email_token=AAAGM5YKP4Z3AWET545WOCLP3HWZVA5CNFSM4HZHIRV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G2KX3IQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAGM545ZNII6RFUSJMQTR3P3HWZVANCNFSM4HZHIRVQ>
.
|
|
This adds an |
|
I just realized that since it's in a string, we can just put it there directly. Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ianjsikes/rust-wasm-webpack-tutorial#7
when using cargo-web's built-in backend, the generated standalone
runtime hardcoded file path as 'xxx.wasm'. It causes error when
the .wasm file is at that location. Thus we use a custom runtime instead to
get the .wasm from the correct location.