Speed up findLongestMatch by avoiding a lot of allocations #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using maps that are recreated anew at each iteration of the loop, allocate two slices once and reuse the old one after cleaning it up. This allocates 35% less and uses 27% less time on real-world cases, and on synthetic benchmarks with long files to diff and a bigger number of similar lines one can observe one tenth the allocations and half the running time.
This patch series contain improvements to both the []strings and [][]byte implementations.