Implement a []byte-base API in a "bytes" subpackage #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 5, 2019 15:03
This doesn't need to be so exact as to care for sha1 collisions.
encoding.binary does too much copies.
It should avoid even more allocations, and be faster too. Also create a custom type for hash results for clarity and ease of change if we need to update the hash.
Now that the bytes API is in its own subpackage, restore the string-only implementation since it is still faster. If the bytes implementation can be optimized further the string API can be made to wrap the bytes implementation, at least partially.
|
It's not 1.5x but 1.3x the time in fact, and it roughly allocates the same amount of data. It wins in the map, but looses in the slices because []byte slices are almost 1.5x the size of []string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with a lot of improvements compared to the current master, it still uses around 1.5x the time of the string-based implementation and API, so put it in a bytes subpackage and restore the original v1.1.2 string implementation in the toplevel package.
When/if the []byte API improves enough (or an interface{}-based one), this decision might be revisited to make the string API a user of the bytes subpackage.