Obsolete #5
Closed
Obsolete #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrnchFrgg
force-pushed
the
master
branch
3 times, most recently
from
30b9bc6 to
ad6fa83
Compare
added 3 commits
November 5, 2019 15:03
This doesn't need to be so exact as to care for sha1 collisions.
added 4 commits
November 5, 2019 15:44
encoding.binary does too much copies.
It should avoid even more allocations, and be faster too. Also create a custom type for hash results for clarity and ease of change if we need to update the hash.
FrnchFrgg
changed the title
FrnchFrgg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that there are less allocations/copies, and so that nothing prevents to change the API to unhashable objects (like []byte)