Avoid holding copies of all lines of b in the internal b2j map #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 3, 2019 13:47
So that it can be improved later.
This way it should avoid a lot of allocations.
|
Note that this paves the way for a change of API to use []bytes, which cannot be used as map keys, but can be hashed by sha1.New() hasher just by replacing NewBufferString with NewBuffer. |
|
(The API change I could write, but then I don't know how you want to preserve compatibility with previous releases) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by using sha1 hashes of the lines as keys. Of course due to (very rare) potential collisions, one hash gives a list of |indices| slices instead of directly the one we want, but we can chose the correct one by comparing the line passed with b[indices[0]].