Skip to content

Make it possible to scrollIntoView() to document.body #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arktds wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make it possible to scrollIntoView() to document.body #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/smoothscroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ function polyfill() {
function findScrollableParent(el) {
var isBody;

if (el === d.body) {
Copy link
Owner

@iamdustan iamdustan Nov 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we did var isBody = el === d.body would this work? Instead of early exiting the rest of the logic will continue working as expected I think.

return el;
}

do {
el = el.parentNode;

Expand Down