Support for redis sentinel #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here I added support for redis sentinel. The configuration options for the database are structured differently than in the original. I will also create a pull request for this change on https://github.com/iamchrismiller/redis-notifier You need to pass redis-sentinel to this if you plan to use sentinel, otherwise pass null or undefined. TODO: need to add unit tests using sentinel.
|
I'll take a look at this tonight! Thanks |
|
Sorry for not getting around to this earlier. Can you add unit tests and I will accept this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for redis sentinel.
Please note, changed the structured of options. Need to pass both redis and sentinel information in a dbConfig section.
Also note that here the name of the package is "redis-sentinel-notifier" and version is 0.3.0 as I was planning to publish on npm fo rmy own use. However, if this pull request is accepted, please keep the original name redis-notifier (if you think that is better).
Thank you
From README file
Here I added support for redis sentinel.
The configuration options for the database are structured differently than in the original.
I will also create a pull request for this change on https://github.com/iamchrismiller/redis-notifier
You need to pass redis-sentinel to this if you plan to use sentinel, otherwise pass null or undefined.
TODO: need to add unit tests using sentinel.