Fix lint issues

.swiftlint.yml

@@ -18,6 +18,8 @@ disabled_rules:
   - shorthand_operator
   - unused_closure_parameter
 
+  - inclusive_language
+
 opt_in_rules:
   - first_where
   - last_where

Form/FormStyle.swift

@@ -18,7 +18,7 @@ public struct FormStyle: Style {
 
 public struct DynamicFormStyle: DynamicStyle {
     public var styleGenerator: (UITraitCollection) -> FormStyle
-    public init(generateStyle : @escaping (UITraitCollection) -> FormStyle) {
+    public init(generateStyle: @escaping (UITraitCollection) -> FormStyle) {
         self.styleGenerator = generateStyle
     }
 }

Form/FormView.swift

@@ -47,7 +47,7 @@ public extension FormView {
             return visibleViews
         }
 
-        //swiftlint:disable:next unused_setter_value
+        // swiftlint:disable superfluous_disable_command unused_setter_value
         set { /* Always computed */ }
     }
 

Form/HeaderFooterStyle.swift

@@ -28,7 +28,7 @@ public struct HeaderFooterStyle: Style {
 
 public struct DynamicHeaderFooterStyle: DynamicStyle {
     public var styleGenerator: (UITraitCollection) -> HeaderFooterStyle
-    public init(generateStyle : @escaping (UITraitCollection) -> HeaderFooterStyle) {
+    public init(generateStyle: @escaping (UITraitCollection) -> HeaderFooterStyle) {
         self.styleGenerator = generateStyle
     }
 }

Form/ParentChildRelational.swift

@@ -88,7 +88,7 @@ public extension ParentChildRelational {
         }
     }
 
-    ///Returns the first ancestor of type `type` if any.
+    /// Returns the first ancestor of type `type` if any.
     func firstAncestor<T>(ofType type: T.Type) -> T? {
         guard let parent = parent else { return nil }
         if let matching = parent as? T {

Form/SectionStyle.swift

@@ -54,7 +54,7 @@ public extension SectionStyle {
 
 public struct DynamicSectionStyle: DynamicStyle {
     public var styleGenerator: (UITraitCollection) -> SectionStyle
-    public init(generateStyle : @escaping (UITraitCollection) -> SectionStyle) {
+    public init(generateStyle: @escaping (UITraitCollection) -> SectionStyle) {
         self.styleGenerator = generateStyle
     }
 }

Form/SectionView.swift

@@ -105,7 +105,7 @@ public extension SectionView {
             return elements
         }
 
-        //swiftlint:disable:next unused_setter_value
+        // swiftlint:disable superfluous_disable_command unused_setter_value
         set { /* Always computed */ }
     }
 

Form/UIScrollView+Keyboard.swift

@@ -51,7 +51,7 @@ public extension UIScrollView {
 }
 
 public extension UIScrollView {
-    //
/ Will dynamically adjust the content offset of `self` to reveal first responders.
+    /// Will dynamically adjust the content offset of `self` to reveal first responders.
     /// Parameter adjustInsets: Function to adjust the frame of the first responder view used to calculate the content offset. Defaults to `alignToRow`.
     /// - Returns: A disposable that will stop adjustments when being disposed.
     func scrollToRevealFirstResponder(_ adjustInsets: @escaping (UIView) -> UIEdgeInsets = alignToRow) -> Disposable {

Form/UIScrollView+Pinning.swift

@@ -189,7 +189,7 @@ private extension UIScrollView {
         switch edge {
         case .bottom:
             // FIXME: enable for iOS 11 if we can remove the re-pin hack
-            //precondition(self[insets: insetKey].bottom == 0, "Only one view can be pinned to bottom")
+            // precondition(self[insets: insetKey].bottom == 0, "Only one view can be pinned to bottom")
             bag += viewHeight.atOnce().onValue { height in
                 self[insets: insetKey].bottom = height
             }
@@ -223,7 +223,7 @@ private extension UIScrollView {
 
         case .top:
             // FIXME: enable for iOS 11 if we can remove the re-pin hack
-            //precondition(self[insets: insetKey].bottom == 0, "Only one view can be pinned to top")
+            // precondition(self[insets: insetKey].bottom == 0, "Only one view can be pinned to top")
             bag += viewHeight.atOnce().onValue { height in
                 self[insets: insetKey].top = height
             }

Form/UIScrollView+Spacing.swift

@@ -57,7 +57,7 @@ public extension UIScrollView {
         disembedBag += { deactivate(constraints) }
 
         // .equalSpacing gives ambigious layout on iOS < 11, help out by calculating spacing manually.
-        if #available(iOS 11, *) {} else if !orderedViews.isEmpty {
+        if #unavailable(iOS 11), !orderedViews.isEmpty {
             let contentHeight = signal(for: \.contentSize)[\.height].toVoid().atValue {
                 for view in orderedViews { view.layoutIfNeeded() }
             }.map {

Form/UITableViewCell+Utilities.swift

@@ -151,10 +151,8 @@ public extension UITableViewCell {
 
 extension UITableViewCell {
     var reorderControlView: UIView? {
-        for view in subviews as [UIView] {
-            if type(of: view).description() == "UITableViewCellReorderControl" {
-                return view
-            }
+        for view in subviews as [UIView] where type(of: view).description() == "UITableViewCellReorderControl" {
+            return view
         }
         return nil
     }
@@ -208,8 +206,8 @@ private extension UITableViewCell {
 // Passing through touches if the touch doesn't hit a subview
 private class TapThroughView: UIView {
     fileprivate override func point(inside point: CGPoint, with event: UIEvent?) -> Bool {
-        for subview in subviews {
-            if subview.point(inside: convert(point, to: subview), with: event) { return true }
+        for subview in subviews where subview.point(inside: convert(point, to: subview), with: event) {
+            return true
         }
         return false
     }

Form/ValueField.swift

@@ -172,7 +172,7 @@ public final class ValueField<Value>: UIControl, UIKeyInput {
         get {
             editor.accessibilityValue
         }
-        //swiftlint:disable:next unused_setter_value
+        // swiftlint:disable superfluous_disable_command unused_setter_value
         set { /* accessibilityValue is always read from the editor. */ }
     }
 
@@ -191,7 +191,7 @@ public final class ValueField<Value>: UIControl, UIKeyInput {
     /// Always use `.no` autocorrection as the system keyboard will be confused if it is used.
     public dynamic var autocorrectionType: UITextAutocorrectionType {
         get { return .no }
-        //swiftlint:disable:next unused_setter_value
+        // swiftlint:disable:next unused_setter_value
         set { /* ignore */ }
     }
 

FormTests/CollectionDiffTests.swift

@@ -15,6 +15,7 @@ func changes<T: Hashable>(from old: [T], to new: [T]) -> [ChangeStep<T, Int>] {
 }
 
 func randomizedArray(length: Int) -> [Int] {
+    // swiftlint:disable:next legacy_random
     return (1...length).map { _ in Int(arc4random_uniform(UInt32(length))) }
 }