-
Notifications
You must be signed in to change notification settings - Fork 36
Add FormatSetSelector, FormatSetPanel, make UI more consistent #1456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…wer-components-react into nam/format-set-editing
The UX you've talked to is for desktop apps right? for web apps, are UX also suggesting a backstage? werent there also concerns or requests to not need to do a full pg transition to see changes ? There is def value in exporting some components for now to get feedback so not everything is baked into our test app |
packages/itwin/quantity-formatting/public/locales/en/QuantityFormat.json
Outdated
Show resolved
Hide resolved
I will do this in a separate issue #1470 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 42 out of 52 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- apps/learning-snippets/pnpm-lock.yaml: Language not supported
- packages/itwin/quantity-formatting/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/itwin/quantity-formatting/src/components/quantityformat/FormatSample.tsx:1
- There's an extra closing
</div>tag that was removed but the structure suggests it should have been moved rather than removed. The component now has an unbalanced div structure - there are 4 opening div tags but only 3 closing div tags.
/*---------------------------------------------------------------------------------------------
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/itwin/quantity-formatting/src/components/quantityformat/FormatSetPanel.tsx
Show resolved
Hide resolved
|
please left align the input fields as mentioned previously in other channels |
|
The input fields are left aligned, they just didn't appear so because iTwinUI's inline labels adds left margins to each component within, leaving it feel unbalanced. I edited the styling for the labels to remove that margin, now it looks more balanced:
|
|
@grigasp @saskliutas I updated test viewer to use 5.2.0 core pkgs, some of the e2e test snapshots are failing, looking at the test artifact, seems like some of the tree node's texts aren't truncated, causing small diffs, is that okay to update the snapshots? |
|
The screenshots changed due to recent addition of horizontal scroll to virtualized trees. The reason it wasn't rendering as it should was twofold:
I set up a separate PR that only bumps the versions in test-app and updates the screenshots: #1475. Let's merge that in, then you can merge your PR with |



editableboolean flag to allow users to edit a format set.FormatSetSelector and FormatSetPanel, shown in use in one modal:

small.FormatPanel before:

FormatPanel after:

Also introduces enhancements to quantity formatting feature in the
test-viewerapp, focusing on improved property formatting customization, better management of format sets, and updates to dependencies. New tab panels are introduced, separating customizing a format and a format set from each other.Quantity Formatting Feature Enhancements:
CustomizeFormatPropertyContextMenuItemand related dialog components to allow users to customize the formatting of individual property values directly from the property grid context menu.FormatSetsTabPanelcomponent, providing a tab panel UI for selecting, editing, and managing format sets, including support for test format sets and integration with theFormatManager.Code Organization and Refactoring:
FormatManager,QuantityFormatButton, etc.) into thequantity-formattingdirectory for better code organization and maintainability.Format Manager Improvements:
Enhanced the logic in
FormatManagerto auto-generate format sets from the opened iModel, including improved event handling for unit system changes and format set management.Dependency Updates:
Updated numerous
@itwindependencies inpackage.jsonto their latest5.2.0(and related) versions to ensure compatibility and access to new features, including support forunitSystemanddescriptionproperties of aFormatSet.UI and Styling Adjustments: