Skip to content

Conversation

hl662
Copy link
Contributor

@hl662 hl662 commented Mar 14, 2025

This config means the pnpm audit task in the repo only runs against the root lockfile, not invidivual lockfiles across the monorepo.

(At time of writing) We have 63 high vulnerabilities and 1 critical to fix.

@hl662
Copy link
Contributor Author

hl662 commented Mar 14, 2025

Every package has multiple high vulnerabilities, I would suggest tackling each package's vulns in its own separate PR...

@aruniverse aruniverse marked this pull request as ready for review March 14, 2025 18:25
@aruniverse
Copy link
Member

Running pnpm up -r from the root updates the deps across the entire monorepo, then running audit across each pkg reports less errors than before, for some pkgs completely resolves them.

But the following pkgs still have cves that need to be resolved:

  • @itwin/grouping-mapping-widget
  • @itwin/one-click-lca-react
  • @itwin/reports-config-widget-react

fyi @arnobmallickbsw @itwin/insights-and-reporting-platform

@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "resolve cves",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These messages appear in consumer-facing changelog files - they should have a meaning to consumers and be properly formatted.

Suggested change
"comment": "resolve cves",
"comment": "Bump dependencies.",

@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "resolve cves",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These messages appear in consumer-facing changelog files - they should have a meaning to consumers and be properly formatted.

Suggested change
"comment": "resolve cves",
"comment": "Bump dependencies.",

"editor.trimAutoWhitespace": true,
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true,
// "editor.formatOnSave": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be removed instead of commented-out?

Copy link
Contributor

@mdastous-bentley mdastous-bentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed map-layers and geo-tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants