-
Notifications
You must be signed in to change notification settings - Fork 35
Setup individual audit #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Setup individual audit #1243
Conversation
Every package has multiple high vulnerabilities, I would suggest tackling each package's vulns in its own separate PR... |
Running But the following pkgs still have cves that need to be resolved:
fyi @arnobmallickbsw @itwin/insights-and-reporting-platform |
@@ -0,0 +1,7 @@ | |||
{ | |||
"type": "patch", | |||
"comment": "resolve cves", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These messages appear in consumer-facing changelog files - they should have a meaning to consumers and be properly formatted.
"comment": "resolve cves", | |
"comment": "Bump dependencies.", |
@@ -0,0 +1,7 @@ | |||
{ | |||
"type": "patch", | |||
"comment": "resolve cves", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These messages appear in consumer-facing changelog files - they should have a meaning to consumers and be properly formatted.
"comment": "resolve cves", | |
"comment": "Bump dependencies.", |
"editor.trimAutoWhitespace": true, | ||
"editor.defaultFormatter": "esbenp.prettier-vscode", | ||
"editor.formatOnSave": true, | ||
// "editor.formatOnSave": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these be removed instead of commented-out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed map-layers
and geo-tools
This config means the pnpm audit task in the repo only runs against the root lockfile, not invidivual lockfiles across the monorepo.
(At time of writing) We have 63 high vulnerabilities and 1 critical to fix.