Skip to content

Conversation

@jianfulin
Copy link

  • Updated package version in package.json from 1.0.0 to 1.0.1.
  • Added new setting for preferred file encoding in package.json.
  • Updated localization strings in package.nls.json for file encoding description.
  • Enhanced fileProvider.ts to support multiple file encodings including utf8, cp950, big5, utf16le, and utf16be.
  • Modified macroLanguageTypes.ts to include fileEncoding in LanguageSettings interface.
  • Updated server.ts to manage file encoding settings for each workspace.
  • Added README_TW.md for Traditional Chinese documentation.
  • Created package.i18n.json for Traditional Chinese translations of commands and settings.

- Updated package version in package.json from 1.0.0 to 1.0.1.
- Added new setting for preferred file encoding in package.json.
- Updated localization strings in package.nls.json for file encoding description.
- Enhanced fileProvider.ts to support multiple file encodings including utf8, cp950, big5, utf16le, and utf16be.
- Modified macroLanguageTypes.ts to include fileEncoding in LanguageSettings interface.
- Updated server.ts to manage file encoding settings for each workspace.
- Added README_TW.md for Traditional Chinese documentation.
- Created package.i18n.json for Traditional Chinese translations of commands and settings.
…s for multiple languages

- Updated the version of @vscode/vsce in package.json from 3.0.0 to 3.7.1.
- Added Traditional Chinese localization for macro errors, lint rules, and server messages.
- Added German localization for macro commands and descriptions.
- Added Simplified Chinese localization for macro commands and descriptions.
- Added Traditional Chinese localization for macro commands and descriptions.
This change enhances the parser to support multi-level, nested $INCLUDE files. With limit 8 level.
@iSorp
Copy link
Owner

iSorp commented Jan 1, 2026

Thanks for the work on this!
The overall direction makes sense, but the PR currently is doing too much at once. Please break it down into more atomic changes so each PR addresses a single responsibility.

For 245dcc3 this solves the immediate issue, but we might want to consider a more general solution for handling all supported encodings.
Please try the following:

For encoding, we might want to use the VS Code setting:
vscode://settings/files.encoding

import * as iconv from 'iconv-lite';

const content = readFileSync(URI.parse(uri).fsPath);
const document = TextDocument.create(uri!, 'macro', 1, iconv.decode(content, encoding));

@jianfulin
Copy link
Author

"Thanks for the detailed review! I agree that the PR has grown too large. I’ll close this one, then try to break it down into smaller, atomic PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants