feat(agents): enable ACP builtin agents for team mode via CLI fallback - #719
Draft
ChristianLuciani wants to merge 1 commit into
Draft
feat(agents): enable ACP builtin agents for team mode via CLI fallback#719ChristianLuciani wants to merge 1 commit into
ChristianLuciani wants to merge 1 commit into
Conversation
Remove team_capable_override:false from all builtin ACP agents so runtime inference (is_team_capable -> supports_team_cli_fallback) decides team eligibility instead of a blanket block. Migrations 023, 025, and 029 seed all external ACP agents with team_capable_override:false as a conservative default. This blocks every one of them from joining teams, even when they don't declare shell:false or cli:false in their handshake — meaning the CLI fallback path (which injects $AIONUI_HELPER_BIN and describes team tools as shell commands) would naturally work. The correct gate is the runtime inference: - supports_team_mcp() for agents with MCP transport - supports_team_cli_fallback() for agents that can run shell Removing the override for all builtin ACP agents lets each agent's actual capabilities decide. Agents that later gain MCP support will automatically use the richer Mcp transport. Ref: iOfficeAI#718
ChristianLuciani
force-pushed
the
feat/pi-team-cli-fallback
branch
from
July 29, 2026 18:31
b8e2774 to
c768c0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
team_capable_override: falsefrom all builtin ACP agents so runtime inference decides team eligibility instead of a blanket block.What changed from the first version
The original commit only fixed Pi. But migrations 023, 025, and 029 apply the same
team_capable_override: falseto ~20 agents — not just Pi. Every external ACP agent is blocked from team mode even though most can execute shell commands and would passsupports_team_cli_fallback().The migration now removes the override for all
builtin+acpagents, letting each agent's actual capabilities decide.Why this is the correct default
The runtime inference already has the right gates:
supports_team_mcp()— for agents with MCP transport (stdio/http)supports_team_cli_fallback()— for agents that can execute shell (true unless caps explicitly disable shell/cli)Agents that later gain MCP support will automatically use the richer Mcp transport via
team_tool_transport()with zero changes here.Changes (5 files)
json_removeonteam_capable_overridefor all builtin ACP agentsassert!(pi.team_capable)Verification