Skip to content

feat(agents): enable ACP builtin agents for team mode via CLI fallback - #719

Draft
ChristianLuciani wants to merge 1 commit into
iOfficeAI:mainfrom
ChristianLuciani:feat/pi-team-cli-fallback
Draft

feat(agents): enable ACP builtin agents for team mode via CLI fallback#719
ChristianLuciani wants to merge 1 commit into
iOfficeAI:mainfrom
ChristianLuciani:feat/pi-team-cli-fallback

Conversation

@ChristianLuciani

@ChristianLuciani ChristianLuciani commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Remove team_capable_override: false from all builtin ACP agents so runtime inference decides team eligibility instead of a blanket block.

What changed from the first version

The original commit only fixed Pi. But migrations 023, 025, and 029 apply the same team_capable_override: false to ~20 agents — not just Pi. Every external ACP agent is blocked from team mode even though most can execute shell commands and would pass supports_team_cli_fallback().

The migration now removes the override for all builtin + acp agents, letting each agent's actual capabilities decide.

Why this is the correct default

The runtime inference already has the right gates:

  • supports_team_mcp() — for agents with MCP transport (stdio/http)
  • supports_team_cli_fallback() — for agents that can execute shell (true unless caps explicitly disable shell/cli)

Agents that later gain MCP support will automatically use the richer Mcp transport via team_tool_transport() with zero changes here.

Changes (5 files)

  • Migration 031: json_remove on team_capable_override for all builtin ACP agents
  • registry.rs test: assert!(pi.team_capable)
  • pi_acp_agent_migration test: verify override is absent
  • registry_npx_agents_migration test: same
  • registry_binary_agents_migration test: same

Verification

cargo test -p aionui-db --test pi_acp_agent_migration        #
cargo test -p aionui-db --test registry_npx_agents_migration   #
cargo test -p aionui-db --test registry_binary_agents_migration #
cargo test -p aionui-ai-agent --lib "pi_builtin"               #

Remove team_capable_override:false from all builtin ACP agents so
runtime inference (is_team_capable -> supports_team_cli_fallback)
decides team eligibility instead of a blanket block.

Migrations 023, 025, and 029 seed all external ACP agents with
team_capable_override:false as a conservative default. This blocks
every one of them from joining teams, even when they don't declare
shell:false or cli:false in their handshake — meaning the CLI
fallback path (which injects $AIONUI_HELPER_BIN and describes team
tools as shell commands) would naturally work.

The correct gate is the runtime inference:
  - supports_team_mcp() for agents with MCP transport
  - supports_team_cli_fallback() for agents that can run shell

Removing the override for all builtin ACP agents lets each agent's
actual capabilities decide. Agents that later gain MCP support will
automatically use the richer Mcp transport.

Ref: iOfficeAI#718
@ChristianLuciani
ChristianLuciani force-pushed the feat/pi-team-cli-fallback branch from b8e2774 to c768c0c Compare July 29, 2026 18:31
@ChristianLuciani ChristianLuciani changed the title feat(agents): enable Pi for team mode via CLI fallback feat(agents): enable ACP builtin agents for team mode via CLI fallback Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant