Fix the RP2350 WS2811 driver against the current ws2811UpdateStrip signature

[Raffi1202]

Problem

Every firmware build on maintenance-10.x fails. RP2350_PICO does not compile, and ninja stops the job, so all 16 matrix builds go red with it.

light_ws2811strip_rp2350.c:230: error: too few arguments to function 'ws2811UpdateStrip'
light_ws2811strip_rp2350.c:235: error: conflicting types for 'ws2811UpdateStrip';
                                have 'void(void)', declared 'void(uint16_t)'

df8903bc50 ("Replace whole-strip WS2811 DMA buffer with a bounded, chunked one", merged 17 Sept via #11798) changed ws2811UpdateStrip to take a used-LED count and updated the header and the timer driver, but not the RP2350 driver, which still declared void ws2811UpdateStrip(void) and called it with no arguments.

CI history on maintenance-10.x: last green run is #11804 on 16 Sept; the first red one is the #11798 merge on 17 Sept, and everything after it is red. release/9.1 does not carry df8903bc50 and is unaffected.

Changes

src/main/drivers/light_ws2811strip_rp2350.c:

• ws2811UpdateStrip takes uint16_t usedLedCount, matching light_ws2811strip.h:33
• the count is clamped with MIN(usedLedCount, WS2811_LED_STRIP_LENGTH), the same way light_ws2811strip.c:292 does it; common/maths.h added for MIN
• slots at or beyond the count are written off rather than left latched at their last colour, matching the timer driver's behaviour (light_ws2811strip.c:200-212). The DMA transfer stays full length, so the PIO timing and the reset gap are untouched
• the init call passes WS2811_LED_STRIP_LENGTH, as light_ws2811strip.c:183 does

Test

Not compiled locally, no ARM toolchain on this machine - CI on this PR is the check. Verified statically that the two reported errors cannot recur: the header declaration and both definitions now agree on void(uint16_t), and all four call sites (light_ws2811strip.c:183, light_ws2811strip_rp2350.c:231, ledstrip.c:992, ledstrip.c:1080) pass exactly one argument.

Behaviour on RP2350 hardware is unverified; I have no RP2350 board. The change is confined to which buffer slots get colour data, so a review from someone who can fly it would be welcome.

[qodo-code-review]

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Fix RP2350 WS2811 update signature and inactive LEDs

🐞 Bug fix 🕐 10-20 Minutes

AI Description

• Aligns RP2350 strip updates with the required LED-count parameter.
• Clamps active LEDs and clears unused slots to prevent stale colors.
• Preserves full-length DMA transfers and existing PIO timing.

Diagram

graph TD
    A["Update request"] --> B["Clamp LED count"] --> C{"Slot active?"}
    C -->|Yes| D["Convert HSV to GRB"] --> F["Full-length DMA"]
    C -->|No| E["Write off value"] --> F

Loading

High-Level Assessment

The chosen approach is appropriate: it restores compatibility with the shared API, mirrors the timer driver's count clamping and inactive-slot behavior, and retains full-length DMA transfers to avoid altering PIO timing or reset behavior. Shortening the DMA transfer would introduce unnecessary hardware-timing risk.

Files changed (1) +11 / -2

Bug fix (1) +11 / -2

light_ws2811strip_rp2350.cAlign RP2350 WS2811 updates with the counted-strip API +11/-2

Align RP2350 WS2811 updates with the counted-strip API

• Changes 'ws2811UpdateStrip' to accept and clamp the used LED count, matching the shared declaration and timer implementation. Inactive buffer slots are zeroed before the unchanged full-length DMA transfer, and initialization now supplies the strip length.

src/main/drivers/light_ws2811strip_rp2350.c

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[github-actions]

RAM / Flash usage vs. base commit 884efc7 — commit 7cef6c5

Using the nearest available size baseline — the PR's exact base commit has no stored baseline yet.

Target	Flash Δ	RAM Δ
MATEKF405 ⚠️	+1460 B (+0.21%)	-11616 B (-7.78%)
MATEKF722 ⚠️	+800 B (+0.17%)	-11640 B (-9.28%)
MATEKF765 ⚠️	+984 B (+0.13%)	-11640 B (-6.96%)
MATEKH743 ⚠️	+872 B (+0.11%)	-11552 B (-6.76%)

See RAM/flash optimization guide for techniques to reduce usage.

[github-actions]

Test firmware build ready — commit 7cef6c5

Download firmware for PR #11968

249 targets built. Find your board's .hex file by name on that page (e.g. MATEKF405SE.hex). Files are individually downloadable — no GitHub login required.

Development build for testing only. Use Full Chip Erase when flashing.