Skip to content

Size diff comment noise #11817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sensei-hacker merged 6 commits into from
Aug 24, 2026
Merged

Size diff comment noise #11817

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c5c593d
Merge pull request #11728 from iNavFlight/release/9.1
sensei-hacker Jul 19, 2026
c1ce8e1
Merge pull request #11792 from iNavFlight/release/9.1
sensei-hacker Aug 17, 2026
7470885
Merge pull request #11794 from sensei-hacker/feature-ci-ram-flash-dif…
sensei-hacker Aug 17, 2026
e24bbc7
Merge pull request #11797 from sensei-hacker/feature-ci-ram-flash-dif…
sensei-hacker Aug 18, 2026
47f6afd
Merge pull request #11802 from iNavFlight/release/9.1
sensei-hacker Aug 20, 2026
64c6a3a
size-diff-comment.js Update noise threshold for delta calculations
sensei-hacker Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/size-diff-comment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const REPRESENTATIVE_TARGETS = ['MATEKF405', 'MATEKF722', 'MATEKF765', 'MATEKH74

// Below this magnitude a delta is noise (rounding/toolchain jitter), not a
// real change worth calling out.
const NOISE_THRESHOLD_BYTES = 32;
const NOISE_THRESHOLD_BYTES = 256;

function formatDelta(deltaBytes, baseBytes) {
const sign = deltaBytes > 0 ? '+' : deltaBytes < 0 ? '' : '±';
Expand Down
Loading