Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE -prevent dshot 0048 on forward after reverse #10663

Conversation

pitts-mo
Copy link

@pitts-mo pitts-mo commented Feb 1, 2025

This fix is a working fix for #10648.

However, I can imagine some code/use cases may find it desirable to add reversibleMotorsThrottleState = MOTOR_DIRECTION_NEUTRAL or MOTOR_DIRECTION_DEADBAND state so that the vehicle is not erroneously indicating motor direction FORWARD state while it may still be coasting BACKWARD.

@mmosca
Copy link
Collaborator

mmosca commented Feb 1, 2025

Can you rebase it to maintenance-8.x.x, so it can get added to 8.1?

@pitts-mo pitts-mo changed the base branch from master to maintenance-8.x.x February 1, 2025 11:24
restore INAV VERSION 8.1.0 after re-base
@pitts-mo
Copy link
Author

pitts-mo commented Feb 1, 2025

I am slowly learning the github/code space webgui first time re-baseing to a different branch and resolving a merge conflict. I didn't see an easy way to select the maintenance-8.x.x version of CMakeLists.txt. Please let me know If there is/was a better way to do this.

found the below documentation... thank you -p
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github

@pitts-mo pitts-mo marked this pull request as draft February 2, 2025 00:23
@pitts-mo pitts-mo changed the title prevent dshot 0048 on forward after reverse DO NOT MERGE -prevent dshot 0048 on forward after reverse Feb 2, 2025
@pitts-mo
Copy link
Author

pitts-mo commented Feb 2, 2025

In testing this today I had 4-5 instances in about 30 minute period of operation where it appeared that a transition from reverse to neutral/forward may have been followed by a brief instance of full forward throttle command.

I plan to setup dshot logging, try to repeat this, then revert inav and see if this issue still occurs.

@pitts-mo
Copy link
Author

pitts-mo commented Feb 9, 2025

Closing. See issue #10648

@pitts-mo pitts-mo closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants