docs: fix in-flight OSD menu nav-mode list and status string - #32
sensei-hacker wants to merge 1 commit into
Conversation
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you |
PR Summary by QodoCorrect in-flight OSD menu navigation requirements and status text
AI Description
High-Level Assessment
Files changed (1)
|
|
Thanks for checking this, The OSD string is right. On NAV CRUISE, I think the original wording was actually fine: cruise holds altitude (it activates NAV_ALTHOLD_MODE alongside the heading hold), so it still opens the menu. What was removed in 9d0a691e94 is only the standalone course hold, which locks heading without holding altitude. So I'd keep CRUISE in the list, maybe noting that course hold alone doesn't count |
Hi @cabcrab — thanks for documenting the In-Flight OSD Menu (#18)! While cross-checking it against the firmware source, I noticed two small details that look like they may not match the merged code, and since the page is already live I've put together a proposed correction here. Could I ask you to check whether these are accurate?
cmsIsNavModeActive()insrc/main/cms/cms.cchecks only POSHOLD, RTH, NAV WP, and ALTHOLD (cruise/course-hold was removed in commit9d0a691e94). I've dropped NAV CRUISE from the qualifying-mode list and noted that it doesn't count on its own.USE NAV MODE FOR MENU, but the firmware stringOSD_MSG_MENU_NAV_REQinsrc/main/io/osd.hisUSE NAV MODES FOR MENU(plural). I've aligned it.I checked these against
maintenance-10.xwith the help of an AI-based tool, so please treat any of the above as a question rather than a verdict — happy to adjust anything I've misread. And thank you again for the page!