Apply Sourcery suggested refactoring. #448
Conversation
| TooManyConcurrentRequestsException, | ||
| TooManyExecutionsException, | ||
| TooManyRequestsException, | ||
| UnknownException, |
There was a problem hiding this comment.
Sourcery - Raise specific exception instead of genericException
| self._states = [State(**state) for state in states] | ||
| else: | ||
| self._states = [] | ||
| self._states = [State(**state) for state in states] if states else [] |
There was a problem hiding this comment.
Sourcery - Replace if statement with if expression
| self.event_listener_id: str | None = None | ||
|
|
||
| self.session = session if session else ClientSession() | ||
| self.session = session or ClientSession() |
There was a problem hiding this comment.
Sourcery - Simplify if expression by using or
| # Request access token | ||
| async with self.session.post( | ||
| SOMFY_API + "/oauth/oauth/v2/token", | ||
| f"{SOMFY_API}/oauth/oauth/v2/token", |
There was a problem hiding this comment.
Sourcery - Use f-string instead of string concatenation
| # Request access token | ||
| async with self.session.post( | ||
| SOMFY_API + "/oauth/oauth/v2/token", | ||
| f"{SOMFY_API}/oauth/oauth/v2/token", |
There was a problem hiding this comment.
Sourcery - Use f-string instead of string concatenation
| if "Server is down for maintenance" in result: | ||
| raise MaintenanceException("Server is down for maintenance") from error | ||
| raise Exception( | ||
| raise UnknownException( |
There was a problem hiding this comment.
Sourcery - Raise a specific error instead of the general Exception.
| raise NotSuchTokenException(message) | ||
|
|
||
| raise Exception(message if message else result) | ||
| raise UnknownException(message or result) |
There was a problem hiding this comment.
Sourcery - Raise a specific error instead of the general Exception.
Sourcery - Simplify if expression by using or
| pass | ||
|
|
||
|
|
||
| class UnknownException(Exception): |
There was a problem hiding this comment.
Sourcery - Raise a specific error instead of the general Exception.
| def obfuscate_string(input: str) -> str: | ||
| """Mask string""" | ||
| return re.sub(r"[a-zA-Z0-9_.-]*", "*", str(input)) | ||
| return re.sub(r"[a-zA-Z0-9_.-]*", "*", input) |
There was a problem hiding this comment.
Sourcery - Remove unnecessary casts to int, str, float or bool
| jwt = jwt.strip('"') # Remove surrounding quotes | ||
|
|
||
| return jwt | ||
| return str(jwt) |
There was a problem hiding this comment.
mypy: pyoverkiz/client.py:302: error: Returning Any from function declared to return "str" [no-any-return]
There was a problem hiding this comment.
We should cast it if we know it is a string for sure.
3 participants
Not sure you want to appy that, so I'll make it a draft for now. But I think it's relevant!