Further implementation of language #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
jpaarhuis
changed the base branch from
main
to
feature/add_language_selection
iMicknl
reviewed
Oct 30, 2024
| @@ -30,6 +30,8 @@ This project utilizes several Azure services, requiring an active Azure subscrip | |||
|
|
|||
| Make sure you have Python 3.12+, [uv](https://docs.astral.sh/uv/getting-started/installation/) and optionally the [Azure CLI](https://docs.microsoft.com/en-us/cli/azure/install-azure-cli) installed on your machine. | |||
|
|
|||
| If you're running Windows, also make sure you have installed `cmake`, and adding the `cmake` path to your environment variables. You can do this by installing the C++ Desktop Development workload in the Visual Studio Installer and adding `C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin` to your PATH environment variable. | |||
There was a problem hiding this comment.
Do you know what required cmake on Windows? Was that uv or other python packages?
There was a problem hiding this comment.
"You can do this by installing the C++ Desktop Development workload in the Visual Studio Installer and adding C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin to your PATH environment variable."
There was a problem hiding this comment.
Oh, sorry read your comment wrong. For me the cmake error triggered for PyArrow.
There was a problem hiding this comment.
Thanks! Weird, I would assume that there are precompiled wheels available for Windows...
iMicknl
merged commit f4c5e4e
into
iMicknl:feature/add_language_selection
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.