Skip to content

fix(docker-build): secrets inputs #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TartanLeGrand merged 3 commits into from
Mar 5, 2025
Merged

fix(docker-build): secrets inputs #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ed27ea
fix(docker-build): secrets
TartanLeGrand Mar 5, 2025
5e50380
fix(docker-build): docker secrets instead inputs
TartanLeGrand Mar 5, 2025
1c834c5
Merge branch 'main' into fix/docker-build/secrets-inputs
TartanLeGrand Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions .github/workflows/docker-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,19 @@ name: Build and Push Docker Image
on:
workflow_call:
inputs:
dockerhub-username:
description: 'DockerHub username'
required: true
type: string
dockerhub-pat:
description: 'DockerHub personal access token'
required: true
type: string
dockerfile:
description: 'Path to Dockerfile'
required: true
default: 'Dockerfile'
type: string
image-name:
description: 'Docker image name'
required: true
description: 'Name of Docker Image'
type: string
required: true
secrets:
dockerhub-username:
required: true
dockerhub-pat:
required: true

jobs:
build-and-push:
Expand Down Expand Up @@ -69,8 +66,8 @@ jobs:
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PAT }}
username: ${{ secrets.dockerhub-username }}
password: ${{ secrets.dockerhub-pat }}

- name: Set up QEMU
uses: docker/setup-qemu-action@v3
Expand Down