Skip to content

Conversation

@TartanLeGrand
Copy link
Contributor

This pull request updates the .github/workflows/docker-build.yml file to enhance security reporting capabilities by introducing a new input parameter and associated actions. The most important changes include adding support for a security-report input, modifying conditions for existing steps, and introducing a new step to upload SARIF files to GitHub's Security tab.

Enhancements to security reporting:

  • Added a new security-report input parameter with a default value of 'sarif' and type string. This allows users to specify the desired format for security scan results. ([.github/workflows/docker-build.ymlR22-R25](https://github.com/iExecBlockchainComputing/github-actions-workflows/pull/37/files#diff-3414847e2ad632333f775cabb810f0dc0df61a570365df34750a08b00912fe82R22-R25))
  • Updated the condition for the "Update Pull Request with Security Scan Results" step to check for security-report == 'comment' in addition to the existing conditions. ([.github/workflows/docker-build.ymlL103-R107](https://github.com/iExecBlockchainComputing/github-actions-workflows/pull/37/files#diff-3414847e2ad632333f775cabb810f0dc0df61a570365df34750a08b00912fe82L103-R107))
  • Introduced a new step to upload Trivy scan results in SARIF format to GitHub's Security tab when security-report == 'sarif'. This step uses the github/codeql-action/upload-sarif@v3 action. ([.github/workflows/docker-build.ymlR130-R135](https://github.com/iExecBlockchainComputing/github-actions-workflows/pull/37/files#diff-3414847e2ad632333f775cabb810f0dc0df61a570365df34750a08b00912fe82R130-R135))

@Le-Caignec Le-Caignec self-requested a review April 24, 2025 16:42
@TartanLeGrand TartanLeGrand merged commit 5d6d470 into main Apr 24, 2025
1 check passed
@TartanLeGrand TartanLeGrand deleted the feat/docker-build/add-security-report branch April 24, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants