Skip to content

Commit

Permalink
datapath: fix return type of ndo_start_xmit function
Browse files Browse the repository at this point in the history
Upstream commit:
    commit eddf11e18dff0e8671e06ce54e64cfc843303ab9
    Author: YueHaibing <[email protected]>
    Date:   Wed Sep 26 17:15:38 2018 +0800

    net: ovs: fix return type of ndo_start_xmit function

    The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
    which is a typedef for an enum type, so make sure the implementation in
    this driver has returns 'netdev_tx_t' value, and change the function
    return type to netdev_tx_t.

    Found by coccinelle.

    Signed-off-by: YueHaibing <[email protected]>
    Signed-off-by: David S. Miller <[email protected]>

CC: YueHaibing <[email protected]>
Acked-by: William Tu <[email protected]>
Signed-off-by: Greg Rose <[email protected]>
Signed-off-by: Ben Pfaff <[email protected]>
  • Loading branch information
YueHaibing authored and blp committed Dec 15, 2018
1 parent 2f748bf commit d1cf49e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions datapath/vport-internal_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ static struct internal_dev *internal_dev_priv(struct net_device *netdev)
}

/* Called with rcu_read_lock_bh. */
static int internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev)
static netdev_tx_t
internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev)
{
int len, err;

Expand All @@ -62,7 +63,7 @@ static int internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev)
} else {
netdev->stats.tx_errors++;
}
return 0;
return NETDEV_TX_OK;
}

static int internal_dev_open(struct net_device *netdev)
Expand Down

0 comments on commit d1cf49e

Please sign in to comment.