- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.4k
 
fix: repeat and long press keybinds release #11863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs tests
| 
           i will need some hand-holding through how to create the tests or i'm fine handing this off, up to you.  | 
    
| 
           See the guidelines for more info: https://wiki.hypr.land/Contributing-and-Debugging/PR-Guidelines/#testing-and-ci  | 
    
| 
           i added some tests but i cherry-picked the tests back down to main and they also pass i double checked the bug is still indeed reproducible on main through manual tests so something is off with how keybinds are applied in the test plugin vs prod  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's ok, timings in the runner VM are very inconsistent and unreliable. If they pass, it's ok.
| 
           ok i found the issue wasn't talking about CI runners or tests being flakey this codepath is being hit by   | 
    
| 
           well tests have to pass, you can either remove those that can't be done or try to fix them  | 
    
| 
           was able to instrument sendshortcut tests with kitty there's still some weird behavior but the tests are at least catching the original bugs  | 
    
| 
           great! thanks  | 
    
| 
           oops c-f failed  | 
    
| 
           fixed  | 
    
| 
           now test failed lol  | 
    
| 
           added a polling wait thingy for the prompt now  | 
    
| 
           Are we there yet? :))  | 
    
Describe your PR, what does it fix/add?
repeat bug:
long press bug:
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
ready