-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix null monitors causing panics #302
Fix null monitors causing panics #302
Conversation
2af977c
to
9e7d409
Compare
Ok, so I tested this with ironbar and there's one more problem with event parsing. Specifically here: hyprland-rs/src/event_listener/shared.rs Lines 807 to 811 in c07d326
I'm getting this error in the event listener:
I tested this and the id is actually hyprland-rs/src/event_listener/shared.rs Line 421 in c07d326
and here hyprland-rs/src/event_listener/shared.rs Line 808 in c07d326
instead of a |
If that's the case it should just be a MonitorId type |
Can you guys test, if it works I'll merge |
Tested with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Basically what @chmanie mentioned here
I haven't used
hyprland-rs
yet so some testing is needed by people with actual experience ;)