Skip to content

feature: intial testing for comparisions between older helm exports #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Anmol1696
Copy link
Collaborator

Part of: #695

@Anmol1696 Anmol1696 requested a review from Copilot July 10, 2025 17:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors generated Kubernetes manifests and shell scripts for comparing older Helm exports by:

  • Standardizing multiline YAML blocks and consolidating shell commands.
  • Injecting new TIME_* and TIMEOUT_* environment variables into statefulsets.
  • Aligning targetPort values as integers and introducing transfer-tokens.sh and ibc-connection.sh helper scripts.

Reviewed Changes

Copilot reviewed 67 out of 875 changed files in this pull request and generated no comments.

File Description
packages/.../multi-chain/configmaps/setup-scripts.yaml Reformatted script blocks, added transfer-tokens.sh & ibc-connection.sh.
packages/.../multi-chain/cosmoshub/genesis-statefulset.yaml Added TIME_* and TIMEOUT_* env vars for consensus timeouts.
packages/.../full-builders/registry/service.yaml Changed targetPort quotes to integers, added clusterIP: None.
Comments suppressed due to low confidence (3)

packages/packages/generator/tests/output/builder-tests/multi-chain/configmaps/setup-scripts.yaml:39

  • The loop condition uses the literal string max_tries instead of the variable. It should be while [[ $max_tries -gt 0 ]] to correctly compare the numeric value.
    while [[ max_tries -gt 0 ]]

packages/packages/generator/tests/output/builder-tests/multi-chain/configmaps/setup-scripts.yaml:66

  • Similarly here, the loop will not decrement max_tries properly. Update to while [[ $max_tries -gt 0 ]] to reference the variable.
    while [[ max_tries -gt 0 ]]

packages/packages/generator/tests/output/builder-tests/full-builders/registry/deployment.yaml:92

  • [nitpick] Swapping HTTP-based probes to a TCP socket may mask application-level health issues. Consider retaining an HTTP GET on /health if the service provides a health endpoint.
            tcpSocket:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant