Register Gate Wallet and request publishing @cosmos-kit/gatewallet-extension before merge #569
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rebase and fix the conflicts? |
Hyper-Jinx
force-pushed
the
gate-wallet
branch
from
bd8c4ba to
3583ec5
Compare
|
@pyramation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously integrated Gate Wallet but forgot to register it in the global wallets list, so users couldn’t see or use it. This PR registers Gate Wallet so it becomes available to end users.
What’s changed
packages/cosmos-kit/src/wallets.ts) so it appears in the connector list.@cosmos-kit/gatewallet-extension.Action required (maintainers)
@cosmos-kit/gatewallet-extensionto npm first. This PR depends on the package being available so consumers can resolve the integration at runtime.Impact
Testing
https://chromewebstore.google.com/detail/gate-wallet/cpmkedoipcpimgecpmgpldfpohjplkpp
packages/example: Gate Wallet appears in the wallet list, connects successfully, and transaction signing works.