fix kinode desktop #682
Merged
fix kinode desktop #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.0.0-rc take two
electron was not happy with argon2-browser, specifically with fetching the wasm binary that actually ran argon2 however, the bundle we were using had the wasm binary bundled into it this commit simply removes all methods of acquiring the wasm file and uses the wasm binary bundled within it
nick1udwig
force-pushed
the
hf/fix-kinode-desktop
branch
from
f7495e4 to
901ae28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
electron was not happy with argon2-browser, specifically with fetching the wasm binary that actually ran argon2
however, the bundle we were using had the wasm binary bundled into it
Solution
this PR simply removes all methods of acquiring the wasm file and uses the wasm binary bundled within it
Testing
Docs Update
None
Notes
The original minified code lives here
You can build it yourself from this repo https://github.com/antelle/argon2-browser following these steps antelle/argon2-browser#93