Add context helper method similar to laravel. #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertcht
reviewed
Jul 4, 2025
src/core/src/helpers.php
Outdated
| function context($key = null, $default = null, ?int $coroutineId = null) | ||
| { | ||
| return match (true) { | ||
| is_null($key) => \Hypervel\Context\Context::class, |
There was a problem hiding this comment.
The return value here is a little bit weird. Consider returning context instance here, and proxy function calls to static method?
albertcht
reviewed
Jul 4, 2025
src/core/src/helpers.php
Outdated
| * @param int|null $coroutineId | ||
| * @return string | ||
| */ | ||
| function context_set_multiple(array $values, ?int $coroutineId = null): string |
There was a problem hiding this comment.
This function doesn't exist in Laravel. We can move this method to Context?
There was a problem hiding this comment.
yes we can. I'll do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
context()helper method just like laravel has. But this is different as it is in line with https://hypervel.org/docs/context#context in receiving an optional coroutineId