-
Notifications
You must be signed in to change notification settings - Fork 1.5k
move v2 APIs into v1 APIs #9501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2fd0c5e
to
6ca9ed7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the API structure by consolidating v2 APIs into the standard v1 API package, removing the separate v2 API layer and updating all imports and type references accordingly.
Key changes:
- Consolidates all v2 API types and methods into the standard api package
- Updates imports throughout the codebase from
api.v2
toapi
- Removes the v2-specific server implementation and integrates functionality into the main server
Reviewed Changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
worker/import.go | Updates all type references from apiv2 to api package |
protos/pb/pb_grpc.pb.go | Removes api_v2 import and updates all type references to use api package |
protos/pb.proto | Removes api.v2 import and updates service definitions to use api types |
protos/patch_pb.sh | Adds cross-platform sed function for better macOS/Linux compatibility |
protos/depcheck.sh | Adds homebrew protobuf path support for macOS |
protos/Makefile | Removes api.v2 proto copying and adds homebrew include path |
go.mod | Updates dgo dependency to newer version |
edgraph/zero.go | Changes ServerV25 to Server and updates type references |
edgraph/server.go | Consolidates v2 methods into main Server struct |
edgraph/query.go | Simplifies RunDQL implementation and removes v2-specific logic |
edgraph/ns_query_no_acl_test.go | Removes entire test file |
edgraph/namespace.go | Significantly simplifies namespace operations and removes v2 complexities |
edgraph/alter.go | Removes entire v2-specific alter implementation |
dgraph/cmd/mcp/mcp_server.go | Updates schema setting call to remove namespace parameter |
dgraph/cmd/dgraphimport/import_client.go | Updates client creation to use standard API client |
dgraph/cmd/alpha/run.go | Removes v2 server registration |
.trunk/trunk.yaml | Updates trunk version and linter versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
782b16c
to
ab3ef60
Compare
ab3ef60
to
42609ca
Compare
|
No description provided.