Skip to content

Conversation

mangalaman93
Copy link
Member

No description provided.

@github-actions github-actions bot added area/testing Testing related issues area/core internal mechanisms go Pull requests that update Go code labels Sep 1, 2025
@mangalaman93 mangalaman93 marked this pull request as ready for review September 2, 2025 10:54
@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 10:54
@mangalaman93 mangalaman93 requested a review from a team as a code owner September 2, 2025 10:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the API structure by consolidating v2 APIs into the standard v1 API package, removing the separate v2 API layer and updating all imports and type references accordingly.

Key changes:

  • Consolidates all v2 API types and methods into the standard api package
  • Updates imports throughout the codebase from api.v2 to api
  • Removes the v2-specific server implementation and integrates functionality into the main server

Reviewed Changes

Copilot reviewed 17 out of 19 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
worker/import.go Updates all type references from apiv2 to api package
protos/pb/pb_grpc.pb.go Removes api_v2 import and updates all type references to use api package
protos/pb.proto Removes api.v2 import and updates service definitions to use api types
protos/patch_pb.sh Adds cross-platform sed function for better macOS/Linux compatibility
protos/depcheck.sh Adds homebrew protobuf path support for macOS
protos/Makefile Removes api.v2 proto copying and adds homebrew include path
go.mod Updates dgo dependency to newer version
edgraph/zero.go Changes ServerV25 to Server and updates type references
edgraph/server.go Consolidates v2 methods into main Server struct
edgraph/query.go Simplifies RunDQL implementation and removes v2-specific logic
edgraph/ns_query_no_acl_test.go Removes entire test file
edgraph/namespace.go Significantly simplifies namespace operations and removes v2 complexities
edgraph/alter.go Removes entire v2-specific alter implementation
dgraph/cmd/mcp/mcp_server.go Updates schema setting call to remove namespace parameter
dgraph/cmd/dgraphimport/import_client.go Updates client creation to use standard API client
dgraph/cmd/alpha/run.go Removes v2 server registration
.trunk/trunk.yaml Updates trunk version and linter versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mangalaman93 mangalaman93 changed the title move v2 APIs from v1 APIs move v2 APIs into v1 APIs Sep 2, 2025
@mangalaman93 mangalaman93 enabled auto-merge (squash) September 3, 2025 07:19
Copy link

trunk-io bot commented Sep 3, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestMain The build process for the edgraph component failed. Logs ↗︎

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core internal mechanisms area/testing Testing related issues go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

1 participant