Skip to content

feat: add support for dgraph connection strings #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 4, 2025

Conversation

shivaji-kharse
Copy link
Contributor

@shivaji-kharse shivaji-kharse commented Mar 25, 2025

This PR adds support to open gRPC endpoints using "connection strings", specifically the dgraph.Open() function.

dgraph://{username:password@}host:port?args

username and password are optional. If username is provided, a password must also be present. If supplied, these credentials are used to log into the cluster thru the ACL mechanism.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to
    this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable

Sorry, something went wrong.

@Copilot Copilot bot review requested due to automatic review settings March 25, 2025 20:22
@shivaji-kharse shivaji-kharse requested review from johnymontana and a team as code owners March 25, 2025 20:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@shivaji-kharse shivaji-kharse force-pushed the shiva/connection-string branch 2 times, most recently from 1672bfd to d3f7342 Compare March 26, 2025 12:14
@shivaji-kharse shivaji-kharse changed the title add support for connection strings feat: add support for connection strings Mar 26, 2025
@shivaji-kharse shivaji-kharse changed the title feat: add support for connection strings feat: add support for dgraph connection strings Mar 26, 2025
Copy link
Member

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any existing test that use old way of connecting? If yes, we should replace those to use Open function. LGTM otherwise, approval should be from someone who understands JS more than me.

Copy link
Member

@matthewmcneely matthewmcneely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Don't forget to update the README. You can look at the dgo README as an example.

@octref
Copy link
Member

octref commented Mar 31, 2025

small nitpick but otherwise look good to me

octref
octref previously approved these changes Apr 1, 2025
@shivaji-kharse shivaji-kharse force-pushed the shiva/connection-string branch from 91d8524 to b9a4b73 Compare April 2, 2025 07:31
octref
octref previously approved these changes Apr 3, 2025
Copy link
Member

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, differing to @octref for final approval. Thanks

@mangalaman93 mangalaman93 enabled auto-merge (squash) April 4, 2025 03:56
octref
octref previously approved these changes Apr 4, 2025
@shivaji-kharse shivaji-kharse force-pushed the shiva/connection-string branch 4 times, most recently from a5030bd to e91789c Compare April 4, 2025 09:34
@shivaji-kharse shivaji-kharse force-pushed the shiva/connection-string branch from e91789c to fb9579e Compare April 4, 2025 09:39
@mangalaman93 mangalaman93 merged commit 20f8da7 into main Apr 4, 2025
7 checks passed
@mangalaman93 mangalaman93 deleted the shiva/connection-string branch April 4, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants