-
Notifications
You must be signed in to change notification settings - Fork 52
feat: add support for dgraph connection strings #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
1672bfd
to
d3f7342
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any existing test that use old way of connecting? If yes, we should replace those to use Open function. LGTM otherwise, approval should be from someone who understands JS more than me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Don't forget to update the README. You can look at the dgo README as an example.
small nitpick but otherwise look good to me |
d3f7342
to
a992459
Compare
91d8524
to
b9a4b73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, differing to @octref for final approval. Thanks
a5030bd
to
e91789c
Compare
e91789c
to
fb9579e
Compare
This PR adds support to open gRPC endpoints using "connection strings", specifically the
dgraph.Open()
function.dgraph://{username:password@}host:port?args
username
andpassword
are optional. If username is provided, a password must also be present. If supplied, these credentials are used to log into the cluster thru the ACL mechanism.Checklist
CHANGELOG.md
file describing and linking tothis PR