Skip to content

Conversation

shivaji-kharse
Copy link
Contributor

Reverts #274

@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 10:06
@shivaji-kharse shivaji-kharse requested a review from a team as a code owner September 4, 2025 10:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous revert to restore bidirectional streaming support for external snapshot streaming. It changes the StreamExtSnapshot RPC from client-streaming to bidirectional streaming by enabling server streams and updating the associated client/server interfaces.

  • Enables bidirectional streaming for StreamExtSnapshot RPC method
  • Updates gRPC client and server interfaces to support sending/receiving in both directions
  • Adds a finish field to StreamExtSnapshotResponse message

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
protos/api.v2.proto Updates StreamExtSnapshot RPC definition to bidirectional streaming and adds finish field to response
protos/api.v2/api.v2.pb.go Updates generated protobuf code with new StreamExtSnapshotResponse structure and finish field getter
protos/api.v2/api.v2_grpc.pb.go Updates generated gRPC code with bidirectional streaming interfaces and ServerStreams configuration
.trunk/trunk.yaml Downgrades Go runtime version from 1.25.0 to 1.24.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@shivaji-kharse shivaji-kharse force-pushed the revert-274-revert-266-shiva/bi-stream branch from 533d1d9 to 6633ef2 Compare September 4, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant