Skip to content

Don't allocate in exception handler #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsturtevant merged 1 commit into from
Dec 18, 2025
Merged

Don't allocate in exception handler #1125

jsturtevant merged 1 commit into from
Dec 18, 2025

Conversation

@jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented Dec 17, 2025 •
edited
Loading

Partially addresses: #1118

The test run with out this change fails with memory allocation:

assertion `left == right` failed: Full error: GuestAborted(8, "panicked at /home/jstur/.rustup/toolchains/1.89-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/alloc.rs:438:13:\nmemory allocation of 182 bytes failed")
  left: 8
 right: 15

@jsturtevant jsturtevant added the kind/bugfix For PRs that fix bugs label Dec 17, 2025
@jsturtevant jsturtevant force-pushed the no-allocate-exception-handler branch 2 times, most recently from f678a42 to 22f1513 Compare December 17, 2025 23:33
@jsturtevant
Don't allocate in exception handler
c3d9af1 
Signed-off-by: James Sturtevant <[email protected]>
@jsturtevant jsturtevant force-pushed the no-allocate-exception-handler branch from 22f1513 to c3d9af1 Compare December 17, 2025 23:39
ludfjig
ludfjig reviewed Dec 17, 2025
View reviewed changes
ludfjig
ludfjig approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@ludfjig ludfjig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jsturtevant jsturtevant enabled auto-merge (squash) December 18, 2025 00:13
@jsturtevant jsturtevant merged commit a43f30a into hyperlight-dev:main Dec 18, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludfjig ludfjig ludfjig approved these changes

@danbugs danbugs Awaiting requested review from danbugs danbugs is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

@jprendes jprendes Awaiting requested review from jprendes jprendes is a code owner

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies is a code owner

Assignees

No one assigned

Labels

kind/bugfix For PRs that fix bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsturtevant @ludfjig