Open
Conversation
Contributor
Author
|
@dblnz PTAL |
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
f92eb47 to
8e35f0a
Compare
dblnz
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
0.13.0hyperlight-wasm-runtimecrate, which is required bycrates.iocargo-overlay-registryso that we can dry-run the crate publishingRegarding the last item, since we have interdependent crates in the repo, when we dry-run the
hyperlight-wasm-runtime, it needs thehyperlight-wasm-macrocrate, but thehyperlight-wasm-macrocrate hasn't been published yet, so we can't dry-run it as a standalone crate, i.e., the following will allways fail:A solution is to use workspace publishing, where you can specify more than one package to publish. This is stable since cargo 1.92 (IIRC), so we could do:
The same would apply to
hyperlight-wasm, we would need to dry-run the 3 crates together.The way that cargo makes this work is using an internal overlay registry, located in
./target/package/tmp-registrywhere it temporarely publishes the crates, and uses some internal mechanism to use that overlay registry during verification.HOWEVER, as we are invoking
cargoagain from our buildscript inhyperlight-wasm, that internal mechanism to use the overlay registry is lost, and thecargowe invoke can't find the correct crate because it hasn't been published yet.This PR works around that issue using the
cargo-overlay-registrycrate so that the childcargoalso sees the tmp-registry created bycargo publish.