Use Rust stubs instead of C#28
Merged
jprendes merged 2 commits intohyperlight-dev:mainfrom Mar 3, 2026
Merged
Conversation
jprendes
force-pushed
the
rust-stubs
branch
3 times, most recently
from
370555f to
968eab6
Compare
dblnz
reviewed
Mar 2, 2026
Contributor
dblnz
left a comment
dblnz
left a comment
There was a problem hiding this comment.
Overall it looks good to me. Nice job getting rid of the C sources.
Can we add some tests to the functions in the stubs? For the time related ones at least.
I left some comments.
jsturtevant
reviewed
Mar 3, 2026
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of C stubs with Rust stubs, also removing the
__secs_to_tmfunction taken from the musl codebase.Before we were compiling C files in
build.rswith some stub functions thathyperlight'slibcis missing.Big part of the reason for that is that they took arguments defined as C structs (e.g.,
tm,timespec, etc.) that would be brittle to replicate in rust.With this PR, those types are now being generated with bindgen, so we can write the stubs purely in Rust.