Skip to content

Conversation

@SamYuan1990
Copy link
Contributor

@SamYuan1990 SamYuan1990 commented Apr 17, 2024

public genesisconfig def for people to invoke.

Signed-off-by: Sam Yuan <[email protected]>
@SamYuan1990 SamYuan1990 changed the title action for #187 public genesisconfig def Apr 17, 2024
@SamYuan1990 SamYuan1990 marked this pull request as ready for review April 17, 2024 14:01
@bestbeforetoday
Copy link
Member

I'm not 100% sure what capability is being delivered by exposing this. It seems that the e2e test code makes use of code that is still internal in order to do useful work with the configuration loaded by the genesisconfig package.

The code being made public also includes some content that I'm not sure should be part of the public API:

  • Many "Sample" constants:
    SampleInsecureSoloProfile = "SampleInsecureSolo"
    SampleDevModeSoloProfile = "SampleDevModeSolo"
    SampleSingleMSPSoloProfile = "SampleSingleMSPSolo"
    
    SampleInsecureKafkaProfile = "SampleInsecureKafka"
    SampleDevModeKafkaProfile = "SampleDevModeKafka"
    SampleSingleMSPKafkaProfile = "SampleSingleMSPKafka"
    
    SampleDevModeEtcdRaftProfile = "SampleDevModeEtcdRaft"
    
    SampleAppChannelInsecureSoloProfile = "SampleAppChannelInsecureSolo"
    SampleAppChannelEtcdRaftProfile = "SampleAppChannelEtcdRaft"
    
    SampleSingleMSPChannelProfile = "SampleSingleMSPChannel"
    
    SampleConsortiumName = "SampleConsortium"
    SampleOrgName = "SampleOrg"
  • Code for dealing with Kafka and Solo ordering nodes. Both of these have been deprecated for many years and are being removed from Fabric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants