-
Notifications
You must be signed in to change notification settings - Fork 41
Expose coin price metrics #2683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Itai Segall <[email protected]>
Signed-off-by: Itai Segall <[email protected]>
Signed-off-by: Itai Segall <[email protected]>
Signed-off-by: Itai Segall <[email protected]>
Signed-off-by: Itai Segall <[email protected]>
Signed-off-by: Itai Segall <[email protected]>
…trics Signed-off-by: Itai Segall <[email protected]>
Signed-off-by: Itai Segall <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right to me, thanks a lot!
Did you sanity check on a cluster grafana that the metrics look as expected? Might be a good TODO before cutting the release, in case we did miss something here.
Signed-off-by: Itai Segall <[email protected]>
Yes, I did. Didn't trust myself enough to even write the test before looking at Grafana for sanity ;) |
…trics Signed-off-by: Itai Segall <[email protected]>
Signed-off-by: Itai Segall <[email protected]>
Fixes https://github.com/DACH-NY/canton-network-internal/issues/2181
Will add a dashboard and alerts in a separate PR, but I don't consider that a release blocker so didn't want to delay this PR
Pull Request Checklist
Cluster Testing
/cluster_test
on this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_test
on this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n
, and mention issues worked on using#n
Merge Guidelines