Skip to content

Bump vulnerable HappyDOM version #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 21, 2025
Merged

Bump vulnerable HappyDOM version #2673

merged 11 commits into from
Oct 21, 2025
+186 −179

Conversation

pawelperek-da
Copy link
Contributor

@pawelperek-da pawelperek-da commented Oct 13, 2025 •
edited
Loading

Fixes https://github.com/DACH-NY/canton-network-internal/issues/2311

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@pawelperek-da pawelperek-da force-pushed the pawel/bump-vulnerable-happy-dom-version branch from f584728 to f861348 Compare October 14, 2025 12:43
@pawelperek-da
enable js eval [ci]
fbd15d4 
Signed-off-by: Paweł Perek <[email protected]>
@pawelperek-da pawelperek-da force-pushed the pawel/bump-vulnerable-happy-dom-version branch from f861348 to fbd15d4 Compare October 14, 2025 13:53
@pawelperek-da
fix governance test [ci]
e7a8a3e 
Signed-off-by: Paweł Perek <[email protected]>
@pawelperek-da
fix tests pt.1 [ci]
84dbb63 
Signed-off-by: Paweł Perek <[email protected]>
pawelperek-da
pawelperek-da commented Oct 15, 2025
View reviewed changes
@pawelperek-da
fix tests pt.2 [ci]
bcd7213 
Signed-off-by: Paweł Perek <[email protected]>
@pawelperek-da
fix tests pt.3 [ci]
caa85b4 
Signed-off-by: Paweł Perek <[email protected]>
@pawelperek-da
slightly nicer waiting logic [ci]
40ffd9a 
Signed-off-by: Paweł Perek <[email protected]>
@pawelperek-da
fix tests pt.4 [ci]
f1e3879 
Signed-off-by: Paweł Perek <[email protected]>
@pawelperek-da
disable js eval [ci]
63710de 
Signed-off-by: Paweł Perek <[email protected]>
@pawelperek-da
fix tests pt.5 [ci]
be10dd9 
Signed-off-by: Paweł Perek <[email protected]>
@pawelperek-da
fix tests pt.6 [ci]
4e4b8e5 
Signed-off-by: Paweł Perek <[email protected]>
@pawelperek-da pawelperek-da marked this pull request as ready for review October 16, 2025 13:01
@pawelperek-da
fix whitespaces in mock [ci]
174f6ff 
Signed-off-by: Paweł Perek <[email protected]>
pawelperek-da
pawelperek-da commented Oct 16, 2025
View reviewed changes
apps/common/frontend-test-handlers/src/mocks/helpers/amulet-config-helper.ts
class="jsondiffpatch-node jsondiffpatch-child-node-type-object"><div
class="jsondiffpatch-property-name">decentralizedSynchronizer</div><ul
class="jsondiffpatch-node jsondiffpatch-node-type-object"></ul></li><li
class="jsondiffpatch-node jsondiffpatch-node-type-object"><li
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what's the deal with those diffs but they look roughly correct after pasting them to browser

Copy link
Contributor

@ray-roestenburg-da ray-roestenburg-da Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worries me to be honest, it's weird that this would change? Or is it just more compact or something like that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, afaik there is no reason for this change including new render engine, I will investigate both of those HTMLs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely interested to know why these changed

Copy link
Contributor Author

@pawelperek-da pawelperek-da Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly enough it looks like the HD 20 diff is correct unlike HD 11, check out the screenshots:

  1. First example:
  • 20:
image
  • 11:
image
  1. Second example:
  • 20:
image
  • 11:
image

Current mocks seem to close JSON objects immediately... LMK what you think @fayi-da because TBH I'm not really comfortable with merging these diffs too

@ray-roestenburg-da
Copy link
Contributor

Please do a cluster test

@pawelperek-da
Copy link
Contributor Author

/cluster_test

@github-actions
Copy link

Deploy cluster test triggered for Commit 174f6fff4cf3ef9461ab3b6291e7823e831479f1 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/36769

fayi-da
fayi-da approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@fayi-da fayi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pawelperek-da
Copy link
Contributor Author

/cluster_test

@github-actions
Copy link

Deploy cluster test triggered for Commit 174f6fff4cf3ef9461ab3b6291e7823e831479f1 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/37251

ray-roestenburg-da
ray-roestenburg-da approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@ray-roestenburg-da ray-roestenburg-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pawelperek-da pawelperek-da merged commit ebd1cb7 into main Oct 21, 2025
58 checks passed
@pawelperek-da pawelperek-da deleted the pawel/bump-vulnerable-happy-dom-version branch October 21, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ray-roestenburg-da ray-roestenburg-da ray-roestenburg-da approved these changes

@fayi-da fayi-da fayi-da approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawelperek-da @ray-roestenburg-da @fayi-da