-
Notifications
You must be signed in to change notification settings - Fork 219
feat: deploy staging USDC/eclipsemainnet-ethereum-solanamainnet route #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check Warp Deploy Summary
Last updated: 2025-10-17 14:08:26 UTC |
📝 WalkthroughWalkthroughAdds three new files for the USDCSTAGE warp route: a metadata.json, a tokens config YAML linking Ethereum, Sealevel (eclipsemainnet), and Solana entries, and a deployment YAML describing synthetic and collateral deployment details and addresses. Changes
Sequence Diagram(s)sequenceDiagram
participant Config as Config repo
participant Deployer as Deployment tooling
participant Warp as Warp Routes service
participant Ethereum as Ethereum chain
participant Sealevel as Sealevel (eclipsemainnet)
participant Solana as Solana chain
Note over Config: New files added for USDCSTAGE
Config->>Deployer: provide deploy YAML + token config
Deployer->>Warp: register warp route & tokens
Warp->>Sealevel: link Sealevel synthetic token entry
Warp->>Ethereum: register collateral token & owner
Warp->>Solana: register Solana collateral mapping
Note right of Warp: Route now maps tokens across chains
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
deployments/warp_routes/USDCSTAGE/eclipsemainnet-ethereum-solanamainnet-config.yaml
(1 hunks)deployments/warp_routes/USDCSTAGE/eclipsemainnet-ethereum-solanamainnet-deploy.yaml
(1 hunks)
🧰 Additional context used
🪛 Gitleaks (8.28.0)
deployments/warp_routes/USDCSTAGE/eclipsemainnet-ethereum-solanamainnet-deploy.yaml
[high] 10-10: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: check-warp-deploy
🔇 Additional comments (4)
deployments/warp_routes/USDCSTAGE/eclipsemainnet-ethereum-solanamainnet-deploy.yaml (2)
1-4
: Eclipse and Ethereum deployments look properly configured.The foreign deployment address and collateral setup align with the config file. One thing though—the static analysis flagged line 10 as a potential API key, but that's just a false positive. The address
0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48
is the well-known USDC token on Ethereum mainnet, so no worries there.Just confirm that the Ethereum warp route address (
0x04C26A1Efb87D5Ac9ee6179754B4CDDC61fC11d5
in the config file) is the correct deployment—if you've got that validated on your end, we're good to go.
5-11
: Collateral deployment on Ethereum looks solid.Owner, symbol, and collateral token address are all set. The zero address for interchainSecurityModule is fine if that's the intended setup for staging.
deployments/warp_routes/USDCSTAGE/eclipsemainnet-ethereum-solanamainnet-config.yaml (2)
3-12
: Eclipse token entry is wired up correctly.The eclipsemainnet synthetic token bridges to both Ethereum and Solana properly. Connections reference the right addresses, and the decimals and metadata all line up.
13-22
: Ethereum collateral entry looks good.The token points to the actual USDC on Ethereum, and the collateral address matches what's in the deploy config. Connections to Eclipse are set.
- addressOrDenom: E5rVV8zXwtc4TKGypCJvSBaYbgxa4XaYg5MS6N9QGdeo | ||
chainName: solanamainnet | ||
collateralAddressOrDenom: EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v | ||
connections: | ||
- token: sealevel|eclipsemainnet|6QSWUmEaEcE2KJrU5jq7T11tNRaVsgnG8XULezjg7JjL | ||
decimals: 6 | ||
logoURI: /deployments/warp_routes/USDCSTAGE/logo.svg | ||
name: USDCSTAGE | ||
standard: SealevelHypCollateral | ||
symbol: USDCSTAGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solana collateral setup is valid, but fix the name field inconsistency.
The Solana entry has everything it needs—proper address, collateral reference, and connection back to Eclipse. One thing to tidy up though: line 30 uses USDCSTAGE
for the name, while the Eclipse and Ethereum entries both use USD Coin STAGE
. Keep it consistent.
Apply this diff to match the naming convention:
- name: USDCSTAGE
+ name: USD Coin STAGE
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- addressOrDenom: E5rVV8zXwtc4TKGypCJvSBaYbgxa4XaYg5MS6N9QGdeo | |
chainName: solanamainnet | |
collateralAddressOrDenom: EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v | |
connections: | |
- token: sealevel|eclipsemainnet|6QSWUmEaEcE2KJrU5jq7T11tNRaVsgnG8XULezjg7JjL | |
decimals: 6 | |
logoURI: /deployments/warp_routes/USDCSTAGE/logo.svg | |
name: USDCSTAGE | |
standard: SealevelHypCollateral | |
symbol: USDCSTAGE | |
- addressOrDenom: E5rVV8zXwtc4TKGypCJvSBaYbgxa4XaYg5MS6N9QGdeo | |
chainName: solanamainnet | |
collateralAddressOrDenom: EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v | |
connections: | |
- token: sealevel|eclipsemainnet|6QSWUmEaEcE2KJrU5jq7T11tNRaVsgnG8XULezjg7JjL | |
decimals: 6 | |
logoURI: /deployments/warp_routes/USDCSTAGE/logo.svg | |
name: USD Coin STAGE | |
standard: SealevelHypCollateral | |
symbol: USDCSTAGE |
🤖 Prompt for AI Agents
In
deployments/warp_routes/USDCSTAGE/eclipsemainnet-ethereum-solanamainnet-config.yaml
around lines 23 to 32, the Solana entry uses the name field "USDCSTAGE" which is
inconsistent with the Eclipse and Ethereum entries; change the name value to
"USD Coin STAGE" (matching spacing and casing used elsewhere) so the three
entries share the same display name.
Description
Summary by CodeRabbit
New Features
Chores