Remove unused plugin system with type errors #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After fixing some type errors in @hyperjump/json-schema, it exposed a type issue in the plugin system. We aren't using the plugin system, so I decided to just remove it for now instead of fix it. Something like it can be added in again later if it turns out we need it.
Collaborator
Author
|
Usually I wouldn't do this, but I'm going to merge this with automation failing because the failing test is going to be fixed separately in #90. If I wait for that PR before fixing this, then that PR will have the automation failures this PR is fixing. Either way, one of these PRs will need to be merged in a failing state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing some type errors in
@hyperjump/json-schema, it exposed a type issue in the plugin system. We aren't using the plugin system, so I decided to just remove it for now instead of fix it. Something like it can be added in again later if it turns out we need it. Not sure why we added in the first place.