feat(client/dispatch): TrySendError<T>: std::error::Error
#3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit introduces a `std::error::Error` implementation for `hyper::client::conn::TrySendError`. this allows callers of `hyper::client::conn::http2::SendRequest::try_send_request()` or `hyper::client::conn::http1::SendRequest::try_send_request()` to box a `TrySendError<T>` without discarding a potentially recovered message. a `std::fmt::Display` implementation is added in this commit, because it is a prerequisite for implementations of `std::error::Error`. for some previous discussion on this topic, see "_other options_" here: hyperium#3883 (comment). Ref: hyperium#3883 Ref: hyperium#3892 Signed-off-by: katelyn martin <[email protected]>
cratelyn
added
A-client
This was referenced Jul 29, 2025
seanmonstar
reviewed
Jul 29, 2025
| impl<T> fmt::Display for TrySendError<T> { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| let Self { error, message: _ } = self; | ||
| write!(f, "{}", error) |
There was a problem hiding this comment.
This reminds of the guidelines that an error should either be in the Display, or the source, but not both...
I do think a message like error trying to send request before it was consumed is less useful...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit introduces a
std::error::Errorimplementation forhyper::client::conn::TrySendError.this allows callers of
hyper::client::conn::http2::SendRequest::try_send_request()orhyper::client::conn::http1::SendRequest::try_send_request()to box aTrySendError<T>without discarding a potentially recovered message.a
std::fmt::Displayimplementation is added in this commit, because it is a prerequisite for implementations ofstd::error::Error.for some previous discussion on this topic, see "other options" here: #3883 (comment).
see also:
TrySendError<T>isFrom<Error>#3883try_poll_ready()methods #3892